ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard Zang" <rz...@hortonworks.com>
Subject Re: Review Request 29555: Ambari View: Repo Version Management: Deregister is enabled on current / installed version
Date Mon, 05 Jan 2015 20:15:07 GMT


> On Jan. 5, 2015, 7:59 p.m., Andrii Tkach wrote:
> > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js,
line 54
> > <https://reviews.apache.org/r/29555/diff/1/?file=805990#file805990line54>
> >
> >     No need to load all data when page changed if we use client side pagination,
In general better to create separate ticket to move pagination on client side and use pagination
and filtering on one side client or server, otherwise it becomes confusing,comprehensive and
hard to maintenance

I discussed this with server side folks last week. Currently, server side API does not support
url like "/stacks/repository_versions" from which we can add pagination predicates directly.
That's why I was forced to do client side pagination for repo version listing. I'll log JIRAs
for this.


- Richard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29555/#review66710
-----------------------------------------------------------


On Jan. 3, 2015, 2:18 a.m., Richard Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29555/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2015, 2:18 a.m.)
> 
> 
> Review request for Ambari, Andriy Babiichuk, Andrii Tkach, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-8981
>     https://issues.apache.org/jira/browse/AMBARI-8981
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Do not allow deregistering when repo version's current/installed.
> Fix repo version listing page pagination.
> Some code refactor on listing controller.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
e951c97 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js
0744a9a 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js a0e4ab6

>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 4e93854

>   ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html ef15f1d

> 
> Diff: https://reviews.apache.org/r/29555/diff/
> 
> 
> Testing
> -------
> 
> Manually tested in live cluster. All unit tests successfully passed.
> 
> 
> Thanks,
> 
> Richard Zang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message