ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 29546: Kerberos service components should indicate security state
Date Fri, 02 Jan 2015 18:47:13 GMT


> On Jan. 2, 2015, 1:16 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/status_params.py,
line 33
> > <https://reviews.apache.org/r/29546/diff/1/?file=805728#file805728line33>
> >
> >     preferable to use default() since it performs the key checks, and works with
dictionaries of dictionaries

I am unfamiliar with that, but will look into it an make the change. Thanks.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29546/#review66528
-----------------------------------------------------------


On Jan. 2, 2015, 12:04 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29546/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2015, 12:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle,
and Yusaku Sako.
> 
> 
> Bugs: AMBARI-8480
>     https://issues.apache.org/jira/browse/AMBARI-8480
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Kerberos service components should indicate security state when queried by Ambari
Agent via STATUS_COMMAND.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py
a341e8d 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/status_params.py
PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 6bb29cb 
> 
> Diff: https://reviews.apache.org/r/29546/diff/
> 
> 
> Testing
> -------
> 
> Manually tested in test cluster
> 
> Added new unit test
> 
> #Jenkins test results:
> 
> Running tests for stack:2.2 service:KERBEROS
> test_configure_cross_realm_trust (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_managed_kdc (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_unmanaged_ad (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_unmanaged_kdc (test_kerberos_client.TestKerberosClient) ... ok
> test_get_property (test_kerberos_client.TestKerberosClient) ... ok
> **test_security_status (test_kerberos_client.TestKerberosClient) ... ok**
> test_configure_cross_realm_trust (test_kerberos_server.TestKerberosServer) ... ok
> test_configure_managed_kdc (test_kerberos_server.TestKerberosServer) ... ok
> test_configure_unmanaged_ad (test_kerberos_server.TestKerberosServer) ... ok
> test_configure_unmanaged_kdc (test_kerberos_server.TestKerberosServer) ... ok
> 
> ----------------------------------------------------------------------
> Ran 10 tests in 0.159s
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:09 h
> [INFO] Finished at: 2015-01-02T16:40:56+00:00
> [INFO] Final Memory: 44M/529M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message