ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yurii Shylov" <yurii.shy...@gmail.com>
Subject Re: Review Request 29378: Implement all pre-upgrade checks
Date Fri, 02 Jan 2015 17:58:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29378/
-----------------------------------------------------------

(Updated Янв. 2, 2015, 5:58 п.п.)


Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.


Changes
-------

Fixed according to the comments


Bugs: AMBARI-8898
    https://issues.apache.org/jira/browse/AMBARI-8898


Repository: ambari


Description
-------

The following checks should be implemented:
*All* cluster hosts must satisfy the following:
1) It is either in Host Maintenance Mode or heartbeating with the server
2) If in Host Maintenance Mode, there are no masters on the host
3) If not in Host Maintenance Mode, it must have new version installed
*All* of the following must be satisfied:
1) NameNode HA is enabled
2) Make sure work-preserving RM/NM restart is enabled in YARN configuration files
3) MR Jobs need to reference the Hadoop libraries from the distributed cache instead of the
cluster
4) Tez jobs need to reference the Hadoop libraries from the distributed cache instead of the
cluster
5) Oozie jobs need to reference the Hadoop libraries from the distributed cache instead of
the cluster
6) All services must be up, not in Service Maintenance Mode, and operational (all components
are up and service check should pass*).
7) All DataNode decommissioning must be completed (no DataNode in “decommissioning” state)


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/PreUpgradeCheckRequest.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
0cb20c1 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 1afc850

  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeCheckHelper.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeChecks.java 83cd632 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeCheck.java
0d85a93 
  ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeCheckHelperTest.java PRE-CREATION


Diff: https://reviews.apache.org/r/29378/diff/


Testing
-------

Tests are passing


Thanks,

Yurii Shylov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message