Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============8383452114603520050=="
MIME-Version: 1.0
Subject: Re: Review Request 29517: Zookeeper service components should
 indicate
 security state
From: "Alejandro Fernandez" <afernandez@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Andrew Onischuk" <aonishuk@hortonworks.com>,
 "Sid Wagle" <swagle@hortonworks.com>,
 "Jaimin Jetly" <jaimin@hortonworks.com>,
 "Yusaku Sako" <yusaku@hortonworks.com>
Cc: "Robert Levas" <rlevas@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Wed, 31 Dec 2014 21:41:35 -0000
Message-ID: <20141231214135.31225.13934@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Alejandro Fernandez" <noreply@reviews.apache.org>
References: <20141231212452.31225.41392@reviews.apache.org>
In-Reply-To: <20141231212452.31225.41392@reviews.apache.org>
Reply-To: "Alejandro Fernandez" <afernandez@hortonworks.com>

--===============8383452114603520050==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Dec. 31, 2014, 9:24 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py, line 129
> > <https://reviews.apache.org/r/29517/diff/1/?file=804805#file804805line129>
> >
> >     I suggest using all lowercase for the security_params keys.
> 
> Robert Levas wrote:
>     The names come from a configuration file. Therefore, I don't have control over the case of the key names. However if pushed, I can probaby convert the keys to lowercase when prsing the file, but I think that may lead to confusion.

That's fine, I was curious if it was something that can easily be controlled. Looks good.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29517/#review66484
-----------------------------------------------------------


On Dec. 31, 2014, 6:14 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29517/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2014, 6:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-8797
>     https://issues.apache.org/jira/browse/AMBARI-8797
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Zookeeper service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py 535a53b 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py 36c5c30 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 27cdfc1 
>   ambari-server/src/test/python/stacks/2.0.6/ZOOKEEPER/test_zookeeper_server.py ff3b413 
> 
> Diff: https://reviews.apache.org/r/29517/diff/
> 
> 
> Testing
> -------
> 
> Manually tested in test cluster
> 
> #Jenkins Test Results
> 
> OK
> Running tests for stack:2.0.6 service:ZOOKEEPER
> test_service_check_22 (test_zookeeper_service_check.TestServiceCheck) ... ok
> test_service_check_default (test_zookeeper_service_check.TestServiceCheck) ... ok
> test_service_check_secured (test_zookeeper_service_check.TestServiceCheck) ... ok
> test_configure_default (test_zookeeper_client.TestZookeeperClient) ... ok
> test_configure_secured (test_zookeeper_client.TestZookeeperClient) ... ok
> test_configure_default (test_zookeeper_server.TestZookeeperServer) ... ok
> test_configure_secured (test_zookeeper_server.TestZookeeperServer) ... ok
> **test_security_status (test_zookeeper_server.TestZookeeperServer) ... ok**
> test_start_default (test_zookeeper_server.TestZookeeperServer) ... ok
> test_start_secured (test_zookeeper_server.TestZookeeperServer) ... ok
> test_stop_default (test_zookeeper_server.TestZookeeperServer) ... ok
> test_stop_secured (test_zookeeper_server.TestZookeeperServer) ... ok
> 
> ----------------------------------------------------------------------
> Ran 12 tests in 0.223s
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:08 h
> [INFO] Finished at: 2014-12-31T18:00:17+00:00
> [INFO] Final Memory: 43M/541M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


--===============8383452114603520050==--