Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 685FA10212 for ; Tue, 23 Dec 2014 05:37:55 +0000 (UTC) Received: (qmail 69530 invoked by uid 500); 23 Dec 2014 05:37:55 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 69491 invoked by uid 500); 23 Dec 2014 05:37:55 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 69473 invoked by uid 99); 23 Dec 2014 05:37:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Dec 2014 05:37:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7E93B1D3252; Tue, 23 Dec 2014 05:37:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4948196895787927290==" MIME-Version: 1.0 Subject: Re: Review Request 29158: HDFS service components should indicate security state From: "Robert Levas" To: "Alejandro Fernandez" , "Andrew Onischuk" , "Sid Wagle" , "Jaimin Jetly" , "Yusaku Sako" Cc: "Robert Levas" , "Ambari" Date: Tue, 23 Dec 2014 05:37:53 -0000 Message-ID: <20141223053753.10624.77874@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Robert Levas" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/29158/ X-Sender: "Robert Levas" References: <20141222221455.10621.31230@reviews.apache.org> In-Reply-To: <20141222221455.10621.31230@reviews.apache.org> Reply-To: "Robert Levas" X-ReviewRequest-Repository: ambari --===============4948196895787927290== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Dec. 22, 2014, 5:14 p.m., Jaimin Jetly wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py, line 118 > > > > > > Over here ambari-agent is doing a kinit (authenticating) on behalf of actual component to determine the real time security state of a component. > > > > It will be nice if we can destroy the cached ticket as part of cleanup. > > Robert Levas wrote: > This issue is address by https://issues.apache.org/jira/browse/AMBARI-8870 This is fixed in patch revision 3 - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29158/#review65828 ----------------------------------------------------------- On Dec. 23, 2014, 12:36 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29158/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2014, 12:36 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-8477 > https://issues.apache.org/jira/browse/AMBARI-8477 > > > Repository: ambari > > > Description > ------- > > The HDFS service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND. > > See https://issues.apache.org/jira/browse/AMBARI-8477 for more information. > > > Diffs > ----- > > ambari-agent/src/test/python/resource_management/TestSecurityCommons.py PRE-CREATION > ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py PRE-CREATION > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 4afd4ce > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 3c54e6b > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py f664bcd > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py c8a460f > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 7106422 > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 0027a4c > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py 4102b69 > > Diff: https://reviews.apache.org/r/29158/diff/ > > > Testing > ------- > > Manual tests on a test cluster > Updated test in `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py` > > > Waiting for tests to complete on Jenkins > > > Thanks, > > Robert Levas > > --===============4948196895787927290==--