Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C4C519BF1 for ; Mon, 22 Dec 2014 13:38:04 +0000 (UTC) Received: (qmail 30481 invoked by uid 500); 22 Dec 2014 13:38:04 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 30449 invoked by uid 500); 22 Dec 2014 13:38:04 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 30436 invoked by uid 99); 22 Dec 2014 13:38:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Dec 2014 13:38:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DE7AE1D2C45; Mon, 22 Dec 2014 13:38:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7251020169096418919==" MIME-Version: 1.0 Subject: Re: Review Request 29248: Unit tests for dashboard views From: "Aleksandr Kovalenko" To: "Aleksandr Kovalenko" Cc: "Andrii Tkach" , "Ambari" Date: Mon, 22 Dec 2014 13:38:02 -0000 Message-ID: <20141222133802.10620.62636@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Aleksandr Kovalenko" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/29248/ X-Sender: "Aleksandr Kovalenko" References: <20141222133510.10620.8527@reviews.apache.org> In-Reply-To: <20141222133510.10620.8527@reviews.apache.org> Reply-To: "Aleksandr Kovalenko" X-ReviewRequest-Repository: ambari --===============7251020169096418919== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29248/#review65775 ----------------------------------------------------------- Ship it! Ship It! - Aleksandr Kovalenko On Гру. 22, 2014, 1:35 після полудня, Andrii Tkach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29248/ > ----------------------------------------------------------- > > (Updated Гру. 22, 2014, 1:35 після полудня) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-8819 > https://issues.apache.org/jira/browse/AMBARI-8819 > > > Repository: ambari > > > Description > ------- > > Cover with unit tests following files: > /app/views/main/dashboard/config_history_view > /app/views/main/dashboard/widget > /app/views/main/dashboard/widgets > > > Diffs > ----- > > ambari-web/app/messages.js e341751 > ambari-web/app/views/main/dashboard/config_history_view.js 354cae0 > ambari-web/app/views/main/dashboard/widget.js 95fc5fb > ambari-web/app/views/main/dashboard/widgets.js 107be63 > ambari-web/test/views/main/dashboard/config_history_view_test.js 379bba7 > ambari-web/test/views/main/dashboard/widget_test.js 057b069 > ambari-web/test/views/main/dashboard/widgets_test.js 9ff1d40 > > Diff: https://reviews.apache.org/r/29248/diff/ > > > Testing > ------- > > 5354 tests complete (9 seconds) > 60 tests pending > > > Thanks, > > Andrii Tkach > > --===============7251020169096418919==--