Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EEA271059E for ; Thu, 18 Dec 2014 02:27:04 +0000 (UTC) Received: (qmail 88749 invoked by uid 500); 18 Dec 2014 02:27:04 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 88705 invoked by uid 500); 18 Dec 2014 02:27:04 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 88689 invoked by uid 99); 18 Dec 2014 02:27:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Dec 2014 02:27:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B2E3D1D2415; Thu, 18 Dec 2014 02:27:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0678196666292533311==" MIME-Version: 1.0 Subject: Re: Review Request 29181: [WinGA] Add windows server assembly for AMS From: "Florian Barca" To: "Myroslav Papirkovskyy" , "Sid Wagle" , "Eugene Chekanskiy" Cc: "Ambari" , "Florian Barca" Date: Thu, 18 Dec 2014 02:27:03 -0000 Message-ID: <20141218022703.12942.22675@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Florian Barca" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/29181/ X-Sender: "Florian Barca" References: <20141218000932.12935.62346@reviews.apache.org> In-Reply-To: <20141218000932.12935.62346@reviews.apache.org> Reply-To: "Florian Barca" X-ReviewRequest-Repository: ambari --===============0678196666292533311== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29181/#review65442 ----------------------------------------------------------- ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py The signal we're waiting for is the process stop signal, which is normally not signaled, so, in 99.99% of the cases, that wait will behave exactly as a sleep. But, when the SIGTERM signal arrives, our internal process exit signal gets turned on and then the wait exits immediately. - Florian Barca On Dec. 18, 2014, 12:09 a.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29181/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2014, 12:09 a.m.) > > > Review request for Ambari, Eugene Chekanskiy, Myroslav Papirkovskyy, and Sid Wagle. > > > Bugs: AMBARI-8770 > https://issues.apache.org/jira/browse/AMBARI-8770 > > > Repository: ambari > > > Description > ------- > > Windows build for 2 Ambari Metrics service: Host Monitoring and Timeline Service (Collector). > > + Added Windows profiles to the Maven project files > + Added the necessary Windows assemblies > + Created Windows service skeletons > + Host Monitoring: added OS-independent process termination handler > + Collector: added debugging support for the Java process > > > Diffs > ----- > > ambari-metrics/ambari-metrics-host-monitoring/conf/windows/ambari-metrics-monitor.cmd PRE-CREATION > ambari-metrics/ambari-metrics-host-monitoring/pom.xml 206f225268662a31802e9c88a48c98cb3ab963e8 > ambari-metrics/ambari-metrics-host-monitoring/src/main/assemblies/amhm-windows.xml PRE-CREATION > ambari-metrics/ambari-metrics-host-monitoring/src/main/assemblies/empty.xml PRE-CREATION > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py PRE-CREATION > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py daabf37263fce558456cdc978822e41332478d91 > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py 51f0980b82042b5c1b86781f37418457de0066c2 > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py be83250b9a0113b0794a8874f37440c7d53065ec > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py PRE-CREATION > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py 09ae7e4750dc04266a5831626454077da3e71596 > ambari-metrics/ambari-metrics-timelineservice/conf/windows/ambari-metrics-collector.cmd PRE-CREATION > ambari-metrics/ambari-metrics-timelineservice/conf/windows/amc.properties PRE-CREATION > ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-env.cmd PRE-CREATION > ambari-metrics/ambari-metrics-timelineservice/conf/windows/log4j.properties PRE-CREATION > ambari-metrics/ambari-metrics-timelineservice/pom.xml 01f26fa905adfeebac0b625d3fca58e8399541ae > ambari-metrics/ambari-metrics-timelineservice/src/main/assemblies/ats-windows.xml PRE-CREATION > ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/__init__.py PRE-CREATION > ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/properties.py PRE-CREATION > ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/serviceConfiguration.py PRE-CREATION > ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py PRE-CREATION > ambari-metrics/ambari-metrics-timelineservice/src/main/python/main.py PRE-CREATION > > Diff: https://reviews.apache.org/r/29181/diff/ > > > Testing > ------- > > mvn clean install > > Smoke test on the local machine > > > Thanks, > > Florian Barca > > --===============0678196666292533311==--