Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============5252630651409744722=="
MIME-Version: 1.0
Subject: Re: Review Request 29062: Alerts: Thresholds For Percent Alerts Do
 Not
 Transition To Warning
From: "Jonathan Hurley" <jhurley@hortonworks.com>
To: "Nate Cole" <ncole@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Date: Mon, 15 Dec 2014 22:38:02 -0000
Message-ID: <20141215223802.12942.69368@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Jonathan Hurley" <noreply@reviews.apache.org>
References: <20141215221403.12942.7878@reviews.apache.org>
In-Reply-To: <20141215221403.12942.7878@reviews.apache.org>
Reply-To: "Jonathan Hurley" <jhurley@hortonworks.com>

--===============5252630651409744722==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Dec. 15, 2014, 5:14 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertAggregateListener.java, lines 110-115
> > <https://reviews.apache.org/r/29062/diff/1/?file=792310#file792310line110>
> >
> >     These conditionals (>=) are not consistent with other boundary checks (as in metric_alert.py)  Looks like the changed port_alert.py also uses >=, so we should be consistent (the old nagios didn't use >=, just >)

This came out of a conversation with Jeff about the behavior of the alerts. Given 10 datanodes; if 5 go down, that would mean that 50% are down. If the alerts says "WARNING : 0.5" then administrators would expect an alert to fire at this point in time. However, if the check says .5 > .5 it would not trigger the alert.

We're readying this as "% of alerts affected". So if the value is 50, you're saying if 50% of the alerts are affected, then trigger the state change. I can change it back, but then it won't work as desired. Thoughts?


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29062/#review65132
-----------------------------------------------------------


On Dec. 15, 2014, 4:46 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29062/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2014, 4:46 p.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-8723
>     https://issues.apache.org/jira/browse/AMBARI-8723
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Configured cluster with two DataNodes. Modified the percent DNs available alert to be 10% for warning, 99% for crit. Shutdown one DN and crit alert is fired. Should be warning since only 50% of DNs are affected (not 99%).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionChangedEvent.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionDisabledEvent.java 2fe3ba9 
>   ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 04217f1 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertAggregateListener.java 6d8f34a 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertLifecycleListener.java df95d3d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 23de17e 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java 47d26cb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/Source.java 09ddeb3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java 69f3393 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java 31e93e4 
>   ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java 271c078 
> 
> Diff: https://reviews.apache.org/r/29062/diff/
> 
> 
> Testing
> -------
> 
> Manual tests between 0, 33%, 50% and 100% for WARNING/CRITICAl aggregate definitions. New tests added.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


--===============5252630651409744722==--