Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CE011C8FB for ; Fri, 12 Dec 2014 00:44:02 +0000 (UTC) Received: (qmail 83922 invoked by uid 500); 12 Dec 2014 00:44:02 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 83890 invoked by uid 500); 12 Dec 2014 00:44:02 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 83851 invoked by uid 99); 12 Dec 2014 00:44:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Dec 2014 00:44:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 869B51D22D6; Fri, 12 Dec 2014 00:43:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4251354651125371561==" MIME-Version: 1.0 Subject: Re: Review Request 27871: Provide a way to get service-specific Kerberos descriptor via REST API From: "Jaimin Jetly" To: "Robert Nettleton" , "John Speidel" , "dilli dorai" , "Yusaku Sako" , "Jaimin Jetly" , "Tom Beerbower" Cc: "Robert Levas" , "Ambari" Date: Fri, 12 Dec 2014 00:43:58 -0000 Message-ID: <20141212004358.26419.95891@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jaimin Jetly" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/27871/ X-Sender: "Jaimin Jetly" References: <20141211140304.5766.29249@reviews.apache.org> In-Reply-To: <20141211140304.5766.29249@reviews.apache.org> Reply-To: "Jaimin Jetly" X-ReviewRequest-Repository: ambari --===============4251354651125371561== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27871/#review64832 ----------------------------------------------------------- ambari-server/src/main/resources/properties.json This composite kerberos_descriptor will carry considerable amount of data and Versions reource carry very minimal amount of information regarding stack version. It will be nice to move kerberos_descriptor from being under Versions resource to a parent resource of stack versions API. - Jaimin Jetly On Dec. 11, 2014, 2:03 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27871/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 2:03 p.m.) > > > Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Robert Nettleton, Tom Beerbower, and Yusaku Sako. > > > Bugs: AMBARI-8247 > https://issues.apache.org/jira/browse/AMBARI-8247 > > > Repository: ambari > > > Description > ------- > > Provide a way for a caller via the REST API to get information about a service's Kerberos descriptor. This information should probably be attached to a service resource response. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 60d4f9b > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java 2794c18 > ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java a338a12 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 1296ba1 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 8c9a139 > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 843df0b > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java d025946 > ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 1e1e3a0 > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 0fd8728 > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 5224aaa > ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java b99dcd6 > ambari-server/src/main/resources/properties.json fe67de9 > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 734f4b9 > ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java b6b7190 > ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json PRE-CREATION > ambari-server/src/test/resources/stacks/HDP/2.1.1/services/HDFS/metainfo.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/27871/diff/ > > > Testing > ------- > > Ran all unit tests for ambari-server > Tests run: 2416, Failures: 0, Errors: 0, Skipped: 22 > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 40:22 min > [INFO] Finished at: 2014-12-11T13:14:46+00:00 > [INFO] Final Memory: 43M/503M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > > --===============4251354651125371561==--