Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============4532763471813960030=="
MIME-Version: 1.0
Subject: Re: Review Request 28948: Incorrect / Missing metrics data
From: "Myroslav Papirkovskyy" <mpapyrkovskyy@hortonworks.com>
To: "Myroslav Papirkovskyy" <mpapyrkovskyy@hortonworks.com>,
 "Sid Wagle" <swagle@hortonworks.com>
Cc: "Dmytro Sen" <dsen@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Thu, 11 Dec 2014 17:14:04 -0000
Message-ID: <20141211171404.26419.42822@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Myroslav Papirkovskyy" <noreply@reviews.apache.org>
References: <20141211170701.26419.92029@reviews.apache.org>
In-Reply-To: <20141211170701.26419.92029@reviews.apache.org>
Reply-To: "Myroslav Papirkovskyy" <mpapyrkovskyy@hortonworks.com>

--===============4532763471813960030==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28948/#review64749
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On Гру. 11, 2014, 7:07 після полудня, Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28948/
> -----------------------------------------------------------
> 
> (Updated Гру. 11, 2014, 7:07 після полудня)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-8662
>     https://issues.apache.org/jira/browse/AMBARI-8662
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> looks like cpu metrics are still incremental instead of avg
> Missing disk usage on hosts page.
> Missing yarn graphs
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py 5bc4afb 
>   ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestHostInfo.py 757edbe 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java 9364187 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java cb28a8b 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixTransactSQL.java 93ba2d8 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java 758f5a9 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 50eb08e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 d7a66ab 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java 82f9aff 
>   ambari-server/src/test/resources/ams/multiple_component_regexp_metrics.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28948/diff/
> 
> 
> Testing
> -------
> 
> tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


--===============4532763471813960030==--