Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AF710996F for ; Wed, 10 Dec 2014 20:24:32 +0000 (UTC) Received: (qmail 32226 invoked by uid 500); 10 Dec 2014 20:24:32 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 32173 invoked by uid 500); 10 Dec 2014 20:24:32 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 32144 invoked by uid 99); 10 Dec 2014 20:24:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Dec 2014 20:24:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0D96E1D2327; Wed, 10 Dec 2014 20:24:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6710688843568008071==" MIME-Version: 1.0 Subject: Re: Review Request 28866: Distribute repositories action: Add command report parsing (INSTALLING->INSTALLED) transition From: "Nate Cole" To: "Alejandro Fernandez" , "Mahadev Konar" , "Nate Cole" , "Yurii Shylov" Cc: "Dmitro Lisnichenko" , "Ambari" Date: Wed, 10 Dec 2014 20:24:29 -0000 Message-ID: <20141210202429.26419.8170@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Nate Cole" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/28866/ X-Sender: "Nate Cole" References: <20141210202131.26419.43614@reviews.apache.org> In-Reply-To: <20141210202131.26419.43614@reviews.apache.org> Reply-To: "Nate Cole" X-ReviewRequest-Repository: ambari --===============6710688843568008071== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28866/#review64625 ----------------------------------------------------------- Ship it! Ship It! - Nate Cole On Dec. 10, 2014, 3:21 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28866/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2014, 3:21 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Nate Cole, and Yurii Shylov. > > > Bugs: AMBARI-8618 > https://issues.apache.org/jira/browse/AMBARI-8618 > > > Repository: ambari > > > Description > ------- > > Patch seems to be working end-to-end. UI team may use it for testing. I'll finish last checks tomorrow and deal with unit tests > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/RoleCommand.java b98c50c > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java 6d1d87f > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java b3dcca4 > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java d482109 > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/DistributeRepositoriesStructuredOutput.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 9b7c3c9 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 2886266 > ambari-server/src/main/java/org/apache/ambari/server/events/ActionFinalReportReceivedEvent.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java e708473 > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java 1ce4a73 > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 3308f83 > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 1f14ece > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java a8abd71 > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 3da931f > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java ed1318c > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java e61c1a9 > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java ff406b3 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java d387732 > > Diff: https://reviews.apache.org/r/28866/diff/ > > > Testing > ------- > > Patch seems to be working end-to-end. UI team may use it for testing. I'll finish last checks tomorrow and deal with unit tests > > > Thanks, > > Dmitro Lisnichenko > > --===============6710688843568008071==--