Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 006DF10F94 for ; Wed, 10 Dec 2014 18:08:29 +0000 (UTC) Received: (qmail 41001 invoked by uid 500); 10 Dec 2014 18:08:28 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 40973 invoked by uid 500); 10 Dec 2014 18:08:28 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 40959 invoked by uid 99); 10 Dec 2014 18:08:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Dec 2014 18:08:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6ED2C1D229D; Wed, 10 Dec 2014 18:08:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4889645634882098869==" MIME-Version: 1.0 Subject: Re: Review Request 28902: Config validations not displaying ERRORs From: "Srimanth Gunturi" To: "Vitalyi Brodetskyi" Cc: "Andrew Onischuk" , "Srimanth Gunturi" , "Ambari" Date: Wed, 10 Dec 2014 18:08:25 -0000 Message-ID: <20141210180825.5765.87758@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Srimanth Gunturi" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/28902/ X-Sender: "Srimanth Gunturi" References: <20141210151704.5766.26023@reviews.apache.org> In-Reply-To: <20141210151704.5766.26023@reviews.apache.org> Reply-To: "Srimanth Gunturi" X-ReviewRequest-Repository: ambari --===============4889645634882098869== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28902/#review64579 ----------------------------------------------------------- Tez in HDP-2.2 does not inherit any configs from HDP-2.1 (AMBARI-7921). And Tez HDP-2.2 does not have {{tez.am.java.opts}} config (AMBARI-7935). So 2 fixes are needed # HDP-2.2 _stack_advisor.py_ should not recommend or validate {{tez.am.java.opts}} or any config no longer provided in HDP-2.2 # Ambari UI should display errors/warnings even when there are no config keys. These errors/warnings should show up at the top of the config-page saying {{Value should be set - 'tez.am.java.opts' in 'tez-site'}}. So the patch should include changes in stack_advisor.py in HDP-2.2, and UI javascript changes to make sure errors with no corresponding config show up on top of page - giving chance for user to add. - Srimanth Gunturi On Dec. 10, 2014, 3:17 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28902/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2014, 3:17 p.m.) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-8635 > https://issues.apache.org/jira/browse/AMBARI-8635 > > > Repository: ambari > > > Description > ------- > > Went and changed a tez property, POST /validations is called and the response > returns two things: WARN and ERROR. > > Only the WARN is showing in the UI. Need to also inform the user about ERROR. > > See attached. > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.2/services/TEZ/configuration/tez-site.xml 50345fd > > Diff: https://reviews.apache.org/r/28902/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > > --===============4889645634882098869==--