Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C468710CAA for ; Tue, 9 Dec 2014 18:01:32 +0000 (UTC) Received: (qmail 26718 invoked by uid 500); 9 Dec 2014 18:01:32 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 26683 invoked by uid 500); 9 Dec 2014 18:01:32 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 26670 invoked by uid 99); 9 Dec 2014 18:01:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Dec 2014 18:01:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0D3631D22E0; Tue, 9 Dec 2014 18:01:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2363514937969745940==" MIME-Version: 1.0 Subject: Re: Review Request 28858: UI for pre-upgrade checks From: "Andrii Tkach" To: "Andrii Tkach" Cc: "Andriy Babiichuk" , "Ambari" Date: Tue, 09 Dec 2014 18:01:29 -0000 Message-ID: <20141209180129.5765.612@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Andrii Tkach" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/28858/ X-Sender: "Andrii Tkach" References: <20141209180042.26419.70166@reviews.apache.org> In-Reply-To: <20141209180042.26419.70166@reviews.apache.org> Reply-To: "Andrii Tkach" X-ReviewRequest-Repository: ambari --===============2363514937969745940== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28858/#review64399 ----------------------------------------------------------- Ship it! Ship It! - Andrii Tkach On Дек. 9, 2014, 6 п.п., Andriy Babiichuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28858/ > ----------------------------------------------------------- > > (Updated Дек. 9, 2014, 6 п.п.) > > > Review request for Ambari and Andrii Tkach. > > > Bugs: AMBARI-8611 > https://issues.apache.org/jira/browse/AMBARI-8611 > > > Repository: ambari > > > Description > ------- > > add mocks to UI and popup to show check warnings > > > Diffs > ----- > > ambari-web/app/assets/data/stack_versions/pre_upgrade_check.json PRE-CREATION > ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 159b525 > ambari-web/app/messages.js d0a58f6 > ambari-web/app/templates/main/admin/stack_upgrade/pre_upgrade_check_dialog.hbs PRE-CREATION > ambari-web/app/templates/main/admin/stack_versions/repo_versions.hbs 1a48016 > ambari-web/app/templates/main/admin/stack_versions/stack_versions.hbs dd6a99d > ambari-web/app/utils/ajax/ajax.js 1e55de3 > ambari-web/app/views/main/admin/stack_and_upgrade_view.js 5c5a604 > ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 64a9c7b > > Diff: https://reviews.apache.org/r/28858/diff/ > > > Testing > ------- > > 5063 tests complete (6 seconds) > 60 tests pending > > > Thanks, > > Andriy Babiichuk > > --===============2363514937969745940==--