Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 25A18CAD0 for ; Sat, 6 Dec 2014 01:47:28 +0000 (UTC) Received: (qmail 72905 invoked by uid 500); 6 Dec 2014 01:47:28 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 72859 invoked by uid 500); 6 Dec 2014 01:47:28 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 72845 invoked by uid 99); 6 Dec 2014 01:47:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Dec 2014 01:47:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 11C7F1D2294; Sat, 6 Dec 2014 01:47:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3597737698755562883==" MIME-Version: 1.0 Subject: Re: Review Request 28780: Kerberos Wizard: Implement "Kerberize Cluster" page and "Test Services" page. From: "Yusaku Sako" To: "Yusaku Sako" , "Srimanth Gunturi" Cc: "Ambari" , "Jaimin Jetly" Date: Sat, 06 Dec 2014 01:47:25 -0000 Message-ID: <20141206014725.32526.65922@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Yusaku Sako" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/28780/ X-Sender: "Yusaku Sako" References: <20141206012239.32525.11333@reviews.apache.org> In-Reply-To: <20141206012239.32525.11333@reviews.apache.org> Reply-To: "Yusaku Sako" X-ReviewRequest-Repository: ambari --===============3597737698755562883== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Dec. 6, 2014, 1:22 a.m., Yusaku Sako wrote: > > ambari-web/app/templates/main/admin/kerberos/step5.hbs, line 18 > > > > > > Why "highAvailablity" here? > > Jaimin Jetly wrote: > Thats the common template used accross ambari wizards (HA wizard progress pages, move master wizard progress pages and kerberos wizard progress pages) for wizard progress disaply page. > It makes sense moving this template file it to the more generic loation like commons directory. That will also require changing it's references in all other wizards along with the kerberos wizard. > We can do that refactoring as a seperate task. Ok. That's what I figured. Can you open another JIRA to address the issue and add a TODO comment in the source? - Yusaku ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28780/#review64139 ----------------------------------------------------------- On Dec. 6, 2014, 1:22 a.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28780/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2014, 1:22 a.m.) > > > Review request for Ambari, Srimanth Gunturi and Yusaku Sako. > > > Bugs: AMBARI-8572 > https://issues.apache.org/jira/browse/AMBARI-8572 > > > Repository: ambari > > > Description > ------- > > Apart from implementing "Kerberize Cluster" page and "Test services" page, this patch also removes KDC service component from Kerberos metainfo.xml. > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml 8751892 > ambari-web/app/assets/data/wizard/kerberos/kerberize_cluster.json PRE-CREATION > ambari-web/app/controllers/main/admin/kerberos/step2_controller.js f674f4a > ambari-web/app/controllers/main/admin/kerberos/step3_controller.js 3a4fdbd > ambari-web/app/controllers/main/admin/kerberos/step5_controller.js b15c8cf > ambari-web/app/controllers/main/admin/kerberos/step6_controller.js 800e0c8 > ambari-web/app/data/HDP2/site_properties.js 7971b6a > ambari-web/app/messages.js 7396499 > ambari-web/app/mixins/wizard/wizardProgressPageController.js 63a5fc7 > ambari-web/app/mixins/wizard/wizardProgressPageView.js bbb6420 > ambari-web/app/models/cluster_states.js 9571ea4 > ambari-web/app/routes/add_kerberos_routes.js 4afaedb > ambari-web/app/templates/main/admin/highAvailability/progress.hbs 5f95387 > ambari-web/app/templates/main/admin/kerberos/step5.hbs eadc752 > ambari-web/app/utils/ajax/ajax.js 3d9206e > ambari-web/app/views/main/admin/kerberos/step5_view.js bf46584 > ambari-web/app/views/main/admin/kerberos/wizard_view.js d82786a > > Diff: https://reviews.apache.org/r/28780/diff/ > > > Testing > ------- > > tested kerberos wizard on a live cluster > > > Thanks, > > Jaimin Jetly > > --===============3597737698755562883==--