Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 23FBCC799 for ; Sat, 6 Dec 2014 00:27:52 +0000 (UTC) Received: (qmail 14507 invoked by uid 500); 6 Dec 2014 00:27:52 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 14479 invoked by uid 500); 6 Dec 2014 00:27:52 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 14454 invoked by uid 99); 6 Dec 2014 00:27:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Dec 2014 00:27:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0966B1D2291; Sat, 6 Dec 2014 00:27:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2295253727443741568==" MIME-Version: 1.0 Subject: Re: Review Request 28736: Ambari View > Versions > Versions table + Registration E2E integration From: "Yusaku Sako" To: "Andrii Tkach" , "Yusaku Sako" Cc: "Richard Zang" , "Ambari" Date: Sat, 06 Dec 2014 00:27:49 -0000 Message-ID: <20141206002749.32526.16414@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Yusaku Sako" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/28736/ X-Sender: "Yusaku Sako" References: <20141206001935.32526.20689@reviews.apache.org> In-Reply-To: <20141206001935.32526.20689@reviews.apache.org> Reply-To: "Yusaku Sako" X-ReviewRequest-Repository: ambari --===============2295253727443741568== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28736/#review64128 ----------------------------------------------------------- Thanks for the update. Can you create a JIRA to address these TODOs and comment on the JIRA saying these will be addressed in AMBARI-XXXX? - Yusaku Sako On Dec. 6, 2014, 12:19 a.m., Richard Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28736/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2014, 12:19 a.m.) > > > Review request for Ambari, Andrii Tkach and Yusaku Sako. > > > Bugs: AMBARI-8554 > https://issues.apache.org/jira/browse/AMBARI-8554 > > > Repository: ambari > > > Description > ------- > > Ambari View > Versions > Versions table + Registration E2E integration > > > Diffs > ----- > > ambari-admin/src/main/resources/ui/admin-web/app/assets/data/cluster/clusters.json PRE-CREATION > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js ae984b8 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js 698bc6c > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js c474918 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/StackVersions.js ae499cc > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/create.html 11e954f > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html 97e67c9 > > Diff: https://reviews.apache.org/r/28736/diff/ > > > Testing > ------- > > Manually tested on live cluster. No unit test applicable. > > > Thanks, > > Richard Zang > > --===============2295253727443741568==--