Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1B8671019B for ; Fri, 5 Dec 2014 04:38:30 +0000 (UTC) Received: (qmail 31075 invoked by uid 500); 5 Dec 2014 04:38:30 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 31040 invoked by uid 500); 5 Dec 2014 04:38:30 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 31022 invoked by uid 99); 5 Dec 2014 04:38:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Dec 2014 04:38:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2D66B1D2204; Fri, 5 Dec 2014 04:38:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1381400669998900877==" MIME-Version: 1.0 Subject: Re: Review Request 28491: Create server-side actions to create kerberos principals and keytabs From: "Robert Levas" To: "Robert Nettleton" , "dilli dorai" , "Jaimin Jetly" , "Jonathan Hurley" , "Nate Cole" , "Tom Beerbower" Cc: "Ambari" , "Robert Levas" Date: Fri, 05 Dec 2014 04:38:27 -0000 Message-ID: <20141205043827.32526.71817@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Robert Levas" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/28491/ X-Sender: "Robert Levas" References: <20141202112011.32525.27636@reviews.apache.org> In-Reply-To: <20141202112011.32525.27636@reviews.apache.org> Reply-To: "Robert Levas" X-ReviewRequest-Repository: ambari --===============1381400669998900877== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28491/ ----------------------------------------------------------- (Updated Dec. 4, 2014, 11:38 p.m.) Review request for Ambari, dilli dorai, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower. Changes ------- Optimized creation and cleanup of the KerberosOperation handler as requested by @dilli.dorai Bugs: AMBARI-8454 https://issues.apache.org/jira/browse/AMBARI-8454 Repository: ambari Description ------- Create server-side actions to generate the Kerberos principals and keytabs. These actions will be used when setting up Kerberos for services when Kerberizing a cluster. Diffs (updated) ----- ambari-project/pom.xml edba1dc ambari-server/pom.xml 4076d73 ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredential.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosOperationHandlerTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/28491/diff/ Testing ------- Added new unit tests: Running org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerTest Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.676 sec Running org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec Running org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.465 sec [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 25:36.295s [INFO] Finished at: Wed Nov 26 18:05:30 EST 2014 [INFO] Final Memory: 43M/739M [INFO] ------------------------------------------------------------------------ Thanks, Robert Levas --===============1381400669998900877==--