Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3B90EC7F0 for ; Thu, 4 Dec 2014 13:15:28 +0000 (UTC) Received: (qmail 62580 invoked by uid 500); 4 Dec 2014 13:15:28 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 62554 invoked by uid 500); 4 Dec 2014 13:15:28 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 59284 invoked by uid 99); 4 Dec 2014 02:08:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2014 02:08:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B1F9F1D220D; Thu, 4 Dec 2014 02:08:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2880313491889685511==" MIME-Version: 1.0 Subject: Re: Review Request 28661: Simple view example with UI resources From: "Jeff Sposetti" To: "Yusaku Sako" , "Tom Beerbower" Cc: "Ambari" , "Jeff Sposetti" Date: Thu, 04 Dec 2014 02:08:45 -0000 Message-ID: <20141204020845.32525.93438@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jeff Sposetti" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/28661/ X-Sender: "Jeff Sposetti" References: <20141203225008.32526.76008@reviews.apache.org> In-Reply-To: <20141203225008.32526.76008@reviews.apache.org> Reply-To: "Jeff Sposetti" X-ReviewRequest-Repository: ambari --===============2880313491889685511== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Dec. 3, 2014, 10:50 p.m., Tom Beerbower wrote: > > ambari-views/examples/simple-view/src/main/resources/ui/jquery.min.js, lines 1-3 > > > > > > Is this generated? Does the file require a license header? Downloaded from jquery http://jquery.com/download/ We could (instead) just point to the hosted file and not include this checked in? I'm up for either. - Jeff ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28661/#review63769 ----------------------------------------------------------- On Dec. 4, 2014, 2:08 a.m., Jeff Sposetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28661/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 2:08 a.m.) > > > Review request for Ambari, Tom Beerbower and Yusaku Sako. > > > Bugs: AMBARI-8257 > https://issues.apache.org/jira/browse/AMBARI-8257 > > > Repository: ambari > > > Description > ------- > > > A simple view example that also includes both UI resources and REST endpoint. > > > Diffs > ----- > > ambari-views/examples/simple-view/docs/index.md PRE-CREATION > ambari-views/examples/simple-view/pom.xml PRE-CREATION > ambari-views/examples/simple-view/src/main/java/org/apache/ambari/view/simple/SimpleService.java PRE-CREATION > ambari-views/examples/simple-view/src/main/resources/ui/index.html PRE-CREATION > ambari-views/examples/simple-view/src/main/resources/view.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/28661/diff/ > > > Testing > ------- > > > Thanks, > > Jeff Sposetti > > --===============2880313491889685511==--