Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A907CC9DD for ; Thu, 4 Dec 2014 13:33:36 +0000 (UTC) Received: (qmail 15144 invoked by uid 500); 4 Dec 2014 13:33:36 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 15114 invoked by uid 500); 4 Dec 2014 13:33:36 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 9628 invoked by uid 99); 3 Dec 2014 18:46:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Dec 2014 18:46:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3186A1D219F; Wed, 3 Dec 2014 18:46:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0396551048347312061==" MIME-Version: 1.0 Subject: Re: Review Request 28629: Upgrade Execute: support service groupings in upgrade engine From: "Alejandro Fernandez" To: "Alejandro Fernandez" , "Dmitro Lisnichenko" Cc: "Nate Cole" , "Ambari" Date: Wed, 03 Dec 2014 18:46:54 -0000 Message-ID: <20141203184654.32526.24833@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Alejandro Fernandez" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/28629/ X-Sender: "Alejandro Fernandez" References: <20141203152723.32525.98503@reviews.apache.org> In-Reply-To: <20141203152723.32525.98503@reviews.apache.org> Reply-To: "Alejandro Fernandez" X-ReviewRequest-Repository: ambari --===============0396551048347312061== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28629/#review63702 ----------------------------------------------------------- Ship it! LGTM ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java We can address robustness later. ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml We'll eventually change this to 33. ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml We'll bump this up to 33, can be done in a future patch. - Alejandro Fernandez On Dec. 3, 2014, 3:27 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28629/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 3:27 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko. > > > Bugs: AMBARI-8465 > https://issues.apache.org/jira/browse/AMBARI-8465 > > > Repository: ambari > > > Description > ------- > > Once the backend can support groupings, alter the engine to generate tasks in grouping order. > > Also moved a lot of junk out of UpgradeResourceProvider and into a helper class. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java d0664df > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java d2660e0 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 6980e15 > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java 3057db3 > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Batch.java 4ff0c66 > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConditionalBatch.java e88d67c > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/CountBatch.java c55f569 > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/PercentBatch.java d67bb0b > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RestartTask.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java 4cda5da > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapper.java PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 9fc5752 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 98175ee > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java PRE-CREATION > ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java 947b994 > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 90e907b > > Diff: https://reviews.apache.org/r/28629/diff/ > > > Testing > ------- > > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 14:55.382s > [INFO] Finished at: Tue Dec 02 21:04:42 PST 2014 > [INFO] Final Memory: 27M/317M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > > --===============0396551048347312061==--