Return-Path: 
 <dev-return-49220-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 1B54310FBF
	for <apmail-ambari-dev-archive@www.apache.org>;
 Wed,  3 Dec 2014 02:33:21 +0000 (UTC)
Received: (qmail 26943 invoked by uid 500); 3 Dec 2014 02:33:20 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 26910 invoked by uid 500); 3 Dec 2014 02:33:20 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 26896 invoked by uid 99); 3 Dec 2014 02:33:20 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Dec 2014 02:33:20 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id A93801D217F;
	Wed,  3 Dec 2014 02:33:18 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============5605780021140835970=="
MIME-Version: 1.0
Subject: Review Request 28624: Views: Add new view parameter fields.
From: "Tom Beerbower" <tbeerbower@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Date: Wed, 03 Dec 2014 02:33:18 -0000
Message-ID: <20141203023318.32526.58710@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Tom Beerbower" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-ReviewRequest-URL: https://reviews.apache.org/r/28624/
X-Sender: "Tom Beerbower" <noreply@reviews.apache.org>
Reply-To: "Tom Beerbower" <tbeerbower@hortonworks.com>
X-ReviewRequest-Repository: ambari

--===============5605780021140835970==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28624/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-8519
    https://issues.apache.org/jira/browse/AMBARI-8519


Repository: ambari


Description
-------

Add the following view parameter fields :

# <label> (a user friendly display in the UI). This element is optional. Admin View: If label is not specified, use the name.
# <placeholder> text (used as placeholder text in the UI inputfield). This element is optional. Admin View: If not specified, blank. 
# <default> value. Admin View: if set, use as the default value and shown in the inputfield. This element is optional. This will show instead of placeholder text (if placeholder is specified).

For example ...

{code}
    <parameter>
        <name>ambari.server.username</name>
        <description>Ambari administrator username (for example: admin)</description>

        <label>UserName</label>
        <placeholder>some placeholder text...</placeholder>
        <default>admin</default>

        <required>true</required>
    </parameter>
{code}


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java a944e95 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java 1dd1b5a 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewParameterEntity.java 0c4c70f 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 79e0daa 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 77c7c60 
  ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ParameterConfig.java 827b5e7 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4bd374d 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 9eb4e3a 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql e8f20f6 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 059662f 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 232b283 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProviderTest.java 023cba5 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java c920905 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java 519d010 
  ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ParameterConfigTest.java e3350bc 
  ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java 04cbe2b 
  ambari-server/src/test/resources/test_view.xml 5742bfe 
  ambari-views/src/main/resources/view.xsd a9e5b12 

Diff: https://reviews.apache.org/r/28624/diff/


Testing
-------

New unit tests added.  Manual testing for default value.

All existing tests pass ...

Results :

Tests run: 2316, Failures: 0, Errors: 0, Skipped: 22


Thanks,

Tom Beerbower


--===============5605780021140835970==--