Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============7737874735554161450=="
MIME-Version: 1.0
Subject: Re: Review Request 28565: Fix config settings and emitter code in
 host
 monitor
From: "Myroslav Papirkovskyy" <mpapyrkovskyy@hortonworks.com>
To: "Myroslav Papirkovskyy" <mpapyrkovskyy@hortonworks.com>,
 "Dmytro Sen" <dsen@hortonworks.com>
Cc: "Sid Wagle" <swagle@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Mon, 01 Dec 2014 19:10:47 -0000
Message-ID: <20141201191047.29132.30206@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Myroslav Papirkovskyy" <noreply@reviews.apache.org>
References: <20141201190743.29131.54117@reviews.apache.org>
In-Reply-To: <20141201190743.29131.54117@reviews.apache.org>
Reply-To: "Myroslav Papirkovskyy" <mpapyrkovskyy@hortonworks.com>

--===============7737874735554161450==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28565/#review63413
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On Дек. 1, 2014, 9:07 п.п., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28565/
> -----------------------------------------------------------
> 
> (Updated Дек. 1, 2014, 9:07 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-8499
>     https://issues.apache.org/jira/browse/AMBARI-8499
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - Currently logging level is set to DEBUG in main.py
> - config_reader setting should work with monitor.
> - Fix empty metrics sent to collector.
> {code}
> 2014-11-20 00:46:31,300 DEBUG [1491507836@qtp-48887136-3 - /ws/v1/timeline/metrics] webapp.TimelineWebServices: Storing metrics: {
>   "metrics" : [ ]
> }
> {code}
> 
> Verify that host monitor works end-to-end on a test cluster.
> 
> 
> Diffs
> -----
> 
>   .gitignore 0430303 
>   ambari-metrics/ambari-metrics-host-monitoring/pom.xml b6e44ef 
>   ambari-metrics/ambari-metrics-host-monitoring/src/test/python/unitTests.py 931b02a 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/configuration/ams-site.xml 72ea95f 
> 
> Diff: https://reviews.apache.org/r/28565/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] ambari-metrics .................................... SUCCESS [0.531s]
> [INFO] ambari-metrics-hadoop-sink ........................ SUCCESS [2.368s]
> [INFO] ambari-metrics-hadoop-timelineservice ............. SUCCESS [1:23.564s]
> [INFO] ambari-metrics-host-monitoring .................... SUCCESS [3.688s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:30.397s
> [INFO] Finished at: Mon Dec 01 10:59:58 PST 2014
> [INFO] Final Memory: 45M/463M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


--===============7737874735554161450==--