ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 29432: Add OUT_OF_SYNC set to cluster stack version API
Date Mon, 29 Dec 2014 17:51:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29432/#review66286
-----------------------------------------------------------


Nice, we can finally handle out-of-sync. Eventually, we will lock down the API to add hosts
while the upgrade is in progress; it's good that adding a host requires components to be added
to it, and adding components while the upgrade is in progress will cause the cluster to be
in an out-of-sync state, as expected. It would be unlikely for a user to circumvent the locked
down API, but it's good to have that additional robustness.


ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
<https://reviews.apache.org/r/29432/#comment109679>

    The merge operations need to be transactional.



ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
<https://reviews.apache.org/r/29432/#comment109678>

    Good point.


- Alejandro Fernandez


On Dec. 29, 2014, 4:47 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29432/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2014, 4:47 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-8924
>     https://issues.apache.org/jira/browse/AMBARI-8924
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See Chapter 3.3.2 "Get Single Stack Version" and Chapter 3.6 "OUT_OF_SYNC state and validation"
of Tech Design Doc for details
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
9329ea9 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
d868320 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
3b1b462 
>   ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentInstalledEvent.java
1c31fb7 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java e6067f5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java
304837b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
70a2bba 
>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
98a1826 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
72a22e6 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 374a925

>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
b8e3d5d 
> 
> Diff: https://reviews.apache.org/r/29432/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [3.266s]
> [INFO] Ambari Server ..................................... SUCCESS [31:36.938s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:40.856s
> [INFO] Finished at: Mon Dec 29 18:54:16 FET 2014
> [INFO] Final Memory: 35M/214M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message