ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vitalyi Brodetskyi" <vbrodets...@hortonworks.com>
Subject Re: Review Request 29407: Ambari uses filename that conflicts with python's "mysql" package
Date Wed, 24 Dec 2014 20:49:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29407/#review66054
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Dec. 24, 2014, 8:47 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29407/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2014, 8:47 p.m.)
> 
> 
> Review request for Ambari, Mahadev Konar, Nate Cole, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-8911
>     https://issues.apache.org/jira/browse/AMBARI-8911
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Unit tests fail for me with
> > ----------------------------------------------------------------------
> > Failed tests:
> > ERROR: test_clean_default (test_mysql_server.TestMySqlServer)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> >   File "/media/plextor/ambari/ambari-server/src/test/python/stacks/2.0.6/HIVE/test_mysql_server.py",
line 119, in test_clean_default
> >     target = RMFTestCase.TARGET_COMMON_SERVICES
> >   File "/media/plextor/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
line 110, in executeScript
> >     script_module = imp.load_source(classname, script_path)
> >   File "/media/plextor/ambari/ambari-server/src/test/python/stacks/utils/../../../../main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py",
line 27, in <module>
> >     from mysql import mysql_configure
> > ImportError: cannot import name mysql_configure
> 
> Investigation shows that file ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql.py
is not imported because it conflicts with standard python package "mysql" that is installed
on my machine.
> >>> import mysql
> >>> print mysql
> <module 'mysql' from '/usr/lib/pymodules/python2.7/mysql/__init__.pyc'>
> This code may also fail on some production environments.
> The solution is to rename file at our project
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql.py
 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py
8f77c1c 
> 
> Diff: https://reviews.apache.org/r/29407/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [2.481s]
> [INFO] Ambari Server ..................................... SUCCESS [31.775s]
> [INFO] Ambari Agent ...................................... SUCCESS [14.881s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 49.948s
> [INFO] Finished at: Wed Dec 24 23:47:13 FET 2014
> [INFO] Final Memory: 46M/398M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message