ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 29284: hdp-select set all <version> uses 2.2.0.0 instead of 2.2
Date Sat, 20 Dec 2014 03:37:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29284/
-----------------------------------------------------------

(Updated Dec. 20, 2014, 3:37 a.m.)


Review request for Ambari, Jonathan Hurley, Mahadev Konar, Nate Cole, and Yusaku Sako.


Bugs: AMBARI-8848
    https://issues.apache.org/jira/browse/AMBARI-8848


Repository: ambari


Description
-------

'sudo /usr/bin/hdp-select set all `ambari-python-wrap /usr/bin/hdp-select versions | grep
^2.2.0.0 | tail -1`' will always use 2.2.0.0 because it tries to format 2.2 to have 4 digits
by right-padding with 0s. This causes the hdp-select set all to not function when installing
HDP 2.2.1 stack.


Diffs
-----

  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params.py
19b647e 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
2997867 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py
e10c0ec 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params.py
774e811 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py
dc98526 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py
2327a66 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py
75ea5c5 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params.py
657feba 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params.py
e8a3ac7 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params.py
ec74d77 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py
31162cd 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params.py
1bdc698 
  ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/params.py
ac3c4a0 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-ANY/scripts/params.py 1f85b75

  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py
64c7979 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py
acd45f8 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py fd38d92

  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py
bf9c055 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py
0bf59e1 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 4fbfd22

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py
fda08a0 
  ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KAFKA/package/scripts/params.py
83d6d73 
  ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KNOX/package/scripts/params.py
326d678 
  ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/SLIDER/package/scripts/params.py
467a29f 

Diff: https://reviews.apache.org/r/29284/diff/


Testing (updated)
-------

ABO Unit tests passed, https://builds.apache.org/job/Ambari-trunk-test-patch/1043//console
Verified on a cluster by copying the changed files, then when adding a Service, searched for
"/usr/bin/hdp-select versions | grep" in the logs, and found
Execute['sudo /usr/bin/hdp-select set all `ambari-python-wrap /usr/bin/hdp-select versions
| grep ^2.2 | tail -1`'] {'only_if': 'ls -d /usr/hdp/2.2*'}
As expected.


Thanks,

Alejandro Fernandez


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message