ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Nechiporenko" <onechipore...@apache.org>
Subject Re: Review Request 29254: Admin Web > Version Management: UI tweaks
Date Fri, 19 Dec 2014 16:32:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29254/#review65636
-----------------------------------------------------------

Ship it!


Ship It!

- Oleg Nechiporenko


On Dec. 19, 2014, 4:32 p.m., Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29254/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2014, 4:32 p.m.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-8829
>     https://issues.apache.org/jira/browse/AMBARI-8829
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. Admin nav "Stack Versions" menu label should be "Versions" instead.
> 2. Remove the "Stack" column from the Version tables (both Installed and Updates tabs)
> 3. On Version Distribution page:
> * Remove "Details" section.  
> * Update host counts / install button / install progress / install done.  Note how "Not
Installed" does not show up if already installed on all hosts.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/data/stack_versions/stack_version_all.json b7ea2b02b74d088a2d548d133c15b950ada0a49c

>   ambari-web/app/assets/test/tests.js 620953861a9fb876d4ed985626aadd405358205c 
>   ambari-web/app/controllers.js 7e30431d4e3a9bf064f50d3d917b5f8fa1241ec5 
>   ambari-web/app/controllers/main/admin/stack_versions/repo_version_management_controller.js
PRE-CREATION 
>   ambari-web/app/controllers/main/admin/stack_versions/repo_versions_controller.js 2e4a3c84db1b3160b4925dd325e8ce58c544d65f

>   ambari-web/app/controllers/main/admin/stack_versions/stack_version_details_controller.js
7678c5a30a49f7d69850c2760e0cc7f8cd3d29fb 
>   ambari-web/app/controllers/main/admin/stack_versions/stack_versions_controller.js 1cc8bdc11fafd9d1a07febbb8e9e83603e44cf5b

>   ambari-web/app/mappers/repository_version_mapper.js 5d42fd8c9b77618619ee5636addb08a5de36af6e

>   ambari-web/app/models/stack_version/version.js 6f718ea11ca46e00a16fff82fcbd685eaa353a08

>   ambari-web/app/routes/main.js 6f9613d9dc940dbcdb73c62c8ee264c2cddbe997 
>   ambari-web/app/styles/application.less d8a68eecaefed196402a0c526d8640062dd5b53e 
>   ambari-web/app/templates/main/admin/stack_versions/repo_versions.hbs 4b1d6cf89cd0d63477f766eafd2123c0a99113a2

>   ambari-web/app/templates/main/admin/stack_versions/stack_version_details.hbs c984bdfdd8becd6d75d44bd503243494337a4959

>   ambari-web/app/templates/main/admin/stack_versions/stack_versions.hbs ac6822d4d66c323046557a4ebe9ce00ebc14e898

>   ambari-web/app/utils/ajax/ajax.js c95521746d6336ff19f574a4661b3140706d72fd 
>   ambari-web/app/views/main/admin.js 949d74c97d992a4525faff58d2f82a0e8802e28e 
>   ambari-web/app/views/main/admin/stack_versions/menu.js e4567cf14f4d59e7aaa234d37907b1bbbc6454ab

>   ambari-web/app/views/main/admin/stack_versions/operating_systems.js 03cef25bdf2e9f81b2771cb65c26508549d53fb5

>   ambari-web/app/views/main/admin/stack_versions/repo_version_view.js 9d874ec44938263cb6efd16005fecdb7a4a86a53

>   ambari-web/app/views/main/admin/stack_versions/stack_version_details_view.js f4d213bc3fa9600019eb2aef4a26199b165bb2e3

>   ambari-web/app/views/main/admin/stack_versions/stack_version_view.js 41897faaabebed8f66a60abc2ab7af17464fc98f

>   ambari-web/app/views/main/menu.js 8f6d2ad0737fd164e90e0f79ea9c6318a613fab1 
>   ambari-web/test/controllers/main/admin/stack_version/repo_version_management_controller_test.js
PRE-CREATION 
>   ambari-web/test/controllers/main/admin/stack_version/repo_versions_controller_test.js
19678bccac71d78d3bed3f0897e9e57e0d9732aa 
>   ambari-web/test/controllers/main/admin/stack_version/stack_version_details_controller_test.js
95fa39355a84f0975b070c0f90a678588160e14a 
>   ambari-web/test/controllers/main/admin/stack_version/stack_versions_controller_test.js
9eb4f921ae50f7c317eb090cafc52ed69e0484bb 
>   ambari-web/test/views/main/admin/stack_version/stack_version_details_test.js 61c0cb4189bc521dfd0d0081bd9a331169383d96

> 
> Diff: https://reviews.apache.org/r/29254/diff/
> 
> 
> Testing
> -------
> 
>   5309 tests complete (6 seconds)
>   60 tests pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message