ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 29189: Rolling Upgrade - Upgrade Pack needs a Cluster Post-Upgrade to Finalize
Date Thu, 18 Dec 2014 22:19:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29189/
-----------------------------------------------------------

(Updated Dec. 18, 2014, 10:19 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, Tom Beerbower,
and Yurii Shylov.


Changes
-------

Rebased after Nate's changes.


Bugs: AMBARI-8778
    https://issues.apache.org/jira/browse/AMBARI-8778


Repository: ambari


Description
-------

The Upgrade Pack needs a group for Cluster Post-Upgrade that will have 2 steps,
1. Custom Action to send the hdfs finalize command to the agent
2. Server Action to complete the upgrade by setting all of the host_versions and the cluster_version
from upgraded/upgrading -> current.
The Finalize can only happen once all hosts have been upgraded.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
c733279 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java a5d3ba2 
  ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java a90fcc7

  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
12e84e8 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java 7fd58cd

  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServerActionTask.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServerSideActionTask.java
b98510b 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
836bccb 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java f41aa68

  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml c02ffb8 
  ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java cf5eea3

  ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java 499b6c3

  ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 40eb7f3 

Diff: https://reviews.apache.org/r/29189/diff/


Testing
-------

Verfied this worked on a 1-node cluster.
First, had to comment out the Core Masters and Core Slaves groups in upgrade-2.2.xml since
both of those require HA and manual steps to be working, which are not ready yet.
Then, distributed a repository version, and ran the upgrade pack.

ABO Unit tests failed in an unrelated class. I then reran just that class manually and it
passed.


Tests in error: 
  test220Cardinality(org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest): Unable
to parse stack upgrade file at location: /home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
  test220AutoDeploy(org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest): Unable
to parse stack upgrade file at location: /home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
  test220Dependencies(org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest):
Unable to parse stack upgrade file at location: /home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml

Tests run: 2437, Failures: 0, Errors: 3, Skipped: 13

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:13 min
[INFO] Finished at: 2014-12-18T03:49:05+00:00
[INFO] Final Memory: 24M/214M
[INFO] ------------------------------------------------------------------------


Thanks,

Alejandro Fernandez


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message