ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 29189: Rolling Upgrade - Upgrade Pack needs a Cluster Post-Upgrade to Finalize
Date Thu, 18 Dec 2014 03:02:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29189/#review65448
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/29189/#comment108593>

    Most of this was copied from makeManualActionStage



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
<https://reviews.apache.org/r/29189/#comment108594>

    This is the significant code change.



ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
<https://reviews.apache.org/r/29189/#comment108595>

    This calls the finalize.


- Alejandro Fernandez


On Dec. 18, 2014, 3 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29189/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2014, 3 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-8778
>     https://issues.apache.org/jira/browse/AMBARI-8778
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Upgrade Pack needs a group for Cluster Post-Upgrade that will have 2 steps,
> 1. Custom Action to send the hdfs finalize command to the agent
> 2. Server Action to complete the upgrade by setting all of the host_versions and the
cluster_version from upgraded/upgrading -> current.
> The Finalize can only happen once all hosts have been upgraded.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
71bb22c 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java b450eeb

>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
a90fcc7 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
da784c3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServerActionTask.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
0c4d363 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java
c1e65ca 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml b86aa45 
> 
> Diff: https://reviews.apache.org/r/29189/diff/
> 
> 
> Testing
> -------
> 
> Verfied this worked on a 1-node cluster.
> First, had to comment out the Core Masters and Core Slaves groups in upgrade-2.2.xml
since both of those require HA and manual steps to be working, which are not ready yet.
> Then, distributed a repository version, and ran the upgrade pack.
> 
> Waiting for unit test results.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message