ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Florian Barca" <fba...@hortonworks.com>
Subject Re: Review Request 29181: [WinGA] Add windows server assembly for AMS
Date Thu, 18 Dec 2014 02:50:52 GMT


> On Dec. 18, 2014, 12:46 a.m., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py, line
51
> > <https://reviews.apache.org/r/29181/diff/1/?file=795246#file795246line51>
> >
> >     Emitter is a long running thread, which should continue to run even if there
is an exception on sending metric data.

The signal we're waiting for is the process stop signal, which is normally not signaled, so,
in 99.99% of the cases, that wait will behave exactly as a sleep. But, when the SIGTERM signal
arrives, our internal process exit signal gets turned on and then the wait exits immediately.


- Florian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29181/#review65415
-----------------------------------------------------------


On Dec. 18, 2014, 12:09 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29181/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2014, 12:09 a.m.)
> 
> 
> Review request for Ambari, Eugene Chekanskiy, Myroslav Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-8770
>     https://issues.apache.org/jira/browse/AMBARI-8770
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Windows build for 2 Ambari Metrics service: Host Monitoring and Timeline Service (Collector).
> 
> + Added Windows profiles to the Maven project files
> + Added the necessary Windows assemblies
> + Created Windows service skeletons
> + Host Monitoring: added OS-independent process termination handler
> + Collector: added debugging support for the Java process
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-host-monitoring/conf/windows/ambari-metrics-monitor.cmd
PRE-CREATION 
>   ambari-metrics/ambari-metrics-host-monitoring/pom.xml 206f225268662a31802e9c88a48c98cb3ab963e8

>   ambari-metrics/ambari-metrics-host-monitoring/src/main/assemblies/amhm-windows.xml
PRE-CREATION 
>   ambari-metrics/ambari-metrics-host-monitoring/src/main/assemblies/empty.xml PRE-CREATION

>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py PRE-CREATION

>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
daabf37263fce558456cdc978822e41332478d91 
>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py 51f0980b82042b5c1b86781f37418457de0066c2

>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py be83250b9a0113b0794a8874f37440c7d53065ec

>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py
PRE-CREATION 
>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py 09ae7e4750dc04266a5831626454077da3e71596

>   ambari-metrics/ambari-metrics-timelineservice/conf/windows/ambari-metrics-collector.cmd
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/conf/windows/amc.properties PRE-CREATION

>   ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-env.cmd PRE-CREATION

>   ambari-metrics/ambari-metrics-timelineservice/conf/windows/log4j.properties PRE-CREATION

>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 01f26fa905adfeebac0b625d3fca58e8399541ae

>   ambari-metrics/ambari-metrics-timelineservice/src/main/assemblies/ats-windows.xml PRE-CREATION

>   ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/__init__.py
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/properties.py
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/serviceConfiguration.py
PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py PRE-CREATION

>   ambari-metrics/ambari-metrics-timelineservice/src/main/python/main.py PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/29181/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> Smoke test on the local machine
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message