ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yusaku Sako" <yus...@hortonworks.com>
Subject Re: Review Request 29130: Admin View: Create Repo version form changes
Date Thu, 18 Dec 2014 00:55:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29130/#review65420
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Dec. 17, 2014, 12:56 a.m., Richard Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29130/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 12:56 a.m.)
> 
> 
> Review request for Ambari, Andrii Tkach and Yusaku Sako.
> 
> 
> Bugs: AMBARI-8744
>     https://issues.apache.org/jira/browse/AMBARI-8744
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. Only show stack version having upgrade_packs.
> 2. Right align stack version pull down.
> 3. Add repo version client side validation.
> 4. Add client-side validation to make sure at least one OS is selected.
> 5. Fix unit test.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
e6cc743 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js
034537f 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js aa574c8

>   ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 8136088 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/create.html 20fe4c4

>   ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackversionsListCtrl_test.js
PRE-CREATION 
>   ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackversoinsListCtrl_test.js
8865180 
> 
> Diff: https://reviews.apache.org/r/29130/diff/
> 
> 
> Testing
> -------
> 
> Manually tested in live cluster. Unit test fixed.
> 
> 
> Thanks,
> 
> Richard Zang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message