ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 29066: Add method to retrieve KerberosDescriptor from AmbariMetaInfo
Date Tue, 16 Dec 2014 02:53:43 GMT


> On Dec. 15, 2014, 9 p.m., John Speidel wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java,
line 1033
> > <https://reviews.apache.org/r/29066/diff/1/?file=792440#file792440line1033>
> >
> >     should this be an error condition?

yup, if !canRead... thanks.


> On Dec. 15, 2014, 9 p.m., John Speidel wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java,
line 1037
> > <https://reviews.apache.org/r/29066/diff/1/?file=792440#file792440line1037>
> >
> >     Why eat this exception?
> >     Shouldn't this be converted to an AmbariException.
> >     Just dumping the stack isn't a good way of handling and exception.

thanks.. I missed this one when autogenerating catch blocks.


> On Dec. 15, 2014, 9 p.m., John Speidel wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java,
line 1083
> > <https://reviews.apache.org/r/29066/diff/1/?file=792440#file792440line1083>
> >
> >     Why not just call the overloaded getKerberosDescriptor(ServiceInfo) now that
you have a ServiceInfo instance instead of duplication the code?

There was a reason for this in older code, I should have removed it. Removing in next revision.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29066/#review65168
-----------------------------------------------------------


On Dec. 15, 2014, 7:28 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29066/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2014, 7:28 p.m.)
> 
> 
> Review request for Ambari, dilli dorai, John Speidel, Robert Nettleton, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-8722
>     https://issues.apache.org/jira/browse/AMBARI-8722
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add the ability to query the `org.apache.ambari.server.api.services.AmbariMetaInfo` instance
for the KerberosDescriptor for the relevant stack.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
2dd3351 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
cb43321 
>   ambari-server/src/test/resources/stacks/HDP/2.0.8/kerberos.json PRE-CREATION 
>   ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json b61c8b5

> 
> Diff: https://reviews.apache.org/r/29066/diff/
> 
> 
> Testing
> -------
> 
> Updated `org.apache.ambari.server.api.services.AmbariMetaInfo` to test getting Kerberos
Descriptor
> Tests run: 63, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 36.163 sec
> 
> Complete Test Suite:
> Tests run: 2428, Failures: 0, Errors: 0, Skipped: 13
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message