ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 29011: Upgrade Pack definition for Core Slaves Components
Date Mon, 15 Dec 2014 22:19:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29011/#review65128
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode_upgrade.py
<https://reviews.apache.org/r/29011/#comment108087>

    Pydoc uses doublequoted strings.



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode_upgrade.py
<https://reviews.apache.org/r/29011/#comment108091>

    For added robustness (especially if someone else modifies this code block), hdfs_output
should be initialized in the same scope as the try block. I know python doesn't require it,
but I like it as an added check.



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py
<https://reviews.apache.org/r/29011/#comment108093>

    Where is hostname initialized?



ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py
<https://reviews.apache.org/r/29011/#comment108094>

    Awesome, thanks for adding the first unit test related to this!


- Alejandro Fernandez


On Dec. 12, 2014, 10:07 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29011/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2014, 10:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-8694
>     https://issues.apache.org/jira/browse/AMBARI-8694
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create the upgrade pack for upgrades to the following core slaves: HDFS DataNode, YARN
NodeManager.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java 47d26cb

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py
327a457 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode_upgrade.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py
d88e16f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py
0fcf20d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager_upgrade.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py
c1bd382 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 4e6860c 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 18cb30d 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 65e26a4 
> 
> Diff: https://reviews.apache.org/r/29011/diff/
> 
> 
> Testing
> -------
> 
> Executed upgrades of DataNode and NodeManager and verified that their versions changed
after upgrade.
> 
> ------------------------------------------------------------------------
> Ran 246 tests in 3.454s
> 
> OK
> ----------------------------------------------------------------------
> Total run:682
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message