ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 28967: KerberosCredential class should encrypt and decrypt itself
Date Mon, 15 Dec 2014 14:59:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28967/#review65086
-----------------------------------------------------------

Ship it!


Ship It!

- John Speidel


On Dec. 11, 2014, 9:04 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28967/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 9:04 p.m.)
> 
> 
> Review request for Ambari, dilli dorai, John Speidel, Robert Nettleton, Sid Wagle, and
Tom Beerbower.
> 
> 
> Bugs: AMBARI-8660
>     https://issues.apache.org/jira/browse/AMBARI-8660
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Due to the nature of the data, `org.apache.ambari.server.serveraction.kerberos.KerberosCredential`
should provide a facility to encrypt and decrypt itself. 
> 
> For encryption, the caller should provide the KerberosCredential instance and a key.
> 
> For decryption, the caller should provide the encrypted data (base64-encoded string)
and the key.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredential.java
adb2edc 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredentialTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28967/diff/
> 
> 
> Testing
> -------
> 
> Manual tests.
> Created new unit test: `org.apache.ambari.server.serveraction.kerberos.KerberosCredentialTest`
> 
> Test set: org.apache.ambari.server.serveraction.kerberos.KerberosCredentialTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.315 sec
> 
> All tests ran - lost output in buffer
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:45.560s
> [INFO] Finished at: Thu Dec 11 15:50:20 EST 2014
> [INFO] Final Memory: 44M/779M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message