ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Review Request 29002: Fix ignored unit tests for AMBARI-8661 and few production code fixes/improvements
Date Fri, 12 Dec 2014 17:47:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29002/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.


Bugs: AMBARI-8687
    https://issues.apache.org/jira/browse/AMBARI-8687


Repository: ambari


Description
-------

Fixed ignored new unit tests for AMBARI-8661.

Also, included few fixes (tested on live deployment):
Allow reinstall for cluster stack versions in INSTALLED state
use agent.task.timeout property for distribute repositories/install packages action timeout
fix transition to INSTALL_FAILED->INSTALLING state when performing per-host (not cluster-wide)
request

Patch passes unit tests.
I'm going to add few new unit tests for ClusterImpl, but did not finish them yet and that's
why did not include into patch.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
7c533b6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
4850c33 
  ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 453864c

  ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java ed9b0e7

  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 210611b

  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java
aabe366 
  ambari-server/src/test/python/custom_actions/TestCheckHost.py fd289fc 

Diff: https://reviews.apache.org/r/29002/diff/


Testing
-------

[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [4.316s]
[INFO] Ambari Server ..................................... SUCCESS [30:01.257s]
[INFO] Ambari Agent ...................................... SUCCESS [9.103s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 41:06.293s
[INFO] Finished at: Fri Dec 12 20:29:15 FET 2014
[INFO] Final Memory: 33M/181M
[INFO] ------------------------------------------------------------------------


Thanks,

Dmitro Lisnichenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message