ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 28976: Rolling Upgrade - Upgrade Pack to complete HBase
Date Fri, 12 Dec 2014 05:08:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28976/#review64866
-----------------------------------------------------------

Ship it!


I'd be happy to work on a proper solution to the hostname issue.  Ideally the host does not
matter as long as the task is tagged as a server-side action.


ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java
<https://reviews.apache.org/r/28976/#comment107660>

    Wouldn't it be safer to do the following?
    
    ```
    if ((tasks == null) || tasks.isEmpty())
    ```
    
    Maybe `getTasksByHostRoldAndStatus` never returns `null` and this is overkill, but it
make me feel better whenever I see protection against `null` :)



ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java
<https://reviews.apache.org/r/28976/#comment107661>

    I totally agree with the statement. 
    
    Are you then just picking a random host from the cluster as the hostname?


- Robert Levas


On Dec. 11, 2014, 10:07 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28976/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 10:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Levas, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8675
>     https://issues.apache.org/jira/browse/AMBARI-8675
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> PLEASE READ NOTES IF YOU'RE ASSIGNED TO THIS
> 
> Adds HBase RU capability as well as:
> 
> * Fix for Stage and UpgradeItem requests that bring back all tasks.
> * Fix for specifying a SERVICE_CHECK should look for the specific Role definition.  This
was causing numerous exceptions when trying to resolve the agent's response.
> * Added some code that works around the fact that a server side action must run on Ambari,
but was never coming out of QUEUED.
> 
> Rob:  I know you're not part of rolling upgrade effort, but I had to make a fix to the
ServerActionScheduler and db accessor - can you please review those parts?  This is all part
of the whole "server action on ambari when it's not in the host table" issue.  It's easier
for now to work around it then add ambari to the host table at install time (we need buy-in
at a higher level for that.  read:  Mahadev).  I added a comment that should get special attention
in ServerActionScheduler.doWork().
> 
> Tom:  for the Stage/Task stuff, it looks like Tasks/stage_id wasn't added as a key property,
so a request for a Stage was bringing back all tests.  My unit tests passed and accessing
the endpoint looks good, but please check it out if you have a deployed cluster.  The fix
that Rob is looking at will be important for manual stages to work properly.  (My no-op was
failing to become PENDING, stuck as QUEUED).
> 
> Alejandro:  Please look at the agent and upgrade-pack additions.
> 
> Thanks guys!  I'd be happy to discuss any point in the review if need be.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java
6ff365b 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
e8be3cc 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeItemService.java
a8a7640 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
b646c16 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
3bc5c4e 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
cf025b7 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java
880c596 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java
f89645a 
>   ambari-server/src/main/resources/key_properties.json 0b4fa7b 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py
6cd77e7 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py
8ce1e37 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py
a5b8549 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/upgrade.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 060470f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
c55cde8 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java f40c638

> 
> Diff: https://reviews.apache.org/r/28976/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 2412, Failures: 0, Errors: 0, Skipped: 19
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 22:15.071s
> [INFO] Finished at: Thu Dec 11 21:52:42 EST 2014
> [INFO] Final Memory: 31M/327M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message