ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Review Request 28944: Add Kerberos Configuration Metadata File Builder and Reader
Date Thu, 11 Dec 2014 16:01:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28944/
-----------------------------------------------------------

Review request for Ambari, dilli dorai, John Speidel, and Robert Nettleton.


Bugs: AMBARI-8657
    https://issues.apache.org/jira/browse/AMBARI-8657


Repository: ambari


Description
-------

Provide a facility to write (build) and read a (temporary) file used to hold data needed for
updating the configuration data of services to be configured for Kerberos.

The format of the file should be hidden from the user of this facility, but will be CSV.

Added new classes:
* org.apache.ambari.server.serveraction.kerberos.AbstractKerberosDataFileBuilder
* org.apache.ambari.server.serveraction.kerberos.AbstractKerberosDataFileReader
* org.apache.ambari.server.serveraction.kerberos.KerberosConfigDataFile
* org.apache.ambari.server.serveraction.kerberos.KerberosConfigDataFileBuilder
* org.apache.ambari.server.serveraction.kerberos.KerberosConfigDataFileReader
* org.apache.ambari.server.serveraction.kerberos.KerberosConfigDataFileTest

Updated existing classes to implement abstract builder and reader :
* org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileBuilder
* org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileReader


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosDataFileBuilder.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosDataFileReader.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java
b19e6f4 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java
f3d93f5 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosConfigDataFile.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosConfigDataFileBuilder.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosConfigDataFileReader.java
PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosConfigDataFileTest.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/28944/diff/


Testing
-------

Additional unit test: org.apache.ambari.server.serveraction.kerberos.KerberosConfigDataFileTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.087 sec

Existing unit test: org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.102 sec


[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:46.040s
[INFO] Finished at: Thu Dec 11 10:39:48 EST 2014
[INFO] Final Memory: 45M/774M
[INFO] ------------------------------------------------------------------------


Thanks,

Robert Levas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message