ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 28940: Pass Injector to ServerActionExecutor so objects can be injected into ServerAction implementations
Date Thu, 11 Dec 2014 14:49:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28940/
-----------------------------------------------------------

(Updated Dec. 11, 2014, 9:49 a.m.)


Review request for Ambari, dilli dorai, John Speidel, Nate Cole, Robert Nettleton, and Tom
Beerbower.


Changes
-------

Updated `org.apache.ambari.server.serveraction.ServerActionExecutor` to use `@StaticallyInject`


Bugs: AMBARI-8647
    https://issues.apache.org/jira/browse/AMBARI-8647


Repository: ambari


Description
-------

Pass Injector to ServerActionExecutor so object can be injected into ServerAction implementations.
 

This is needed so that server-side actions can get resources like the AmbariManagementController,
Clusters, or etc...


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java
880c596 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
b389644 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/MockServerAction.java
ba9a5af 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/ServerActionExecutorTest.java
e89477a 

Diff: https://reviews.apache.org/r/28940/diff/


Testing
-------

Performed a serices of manual tests.  Updated `org.apache.ambari.server.serveraction.MockServerAction`
to receive an injected `org.apache.ambari.server.state.Clusters` object for test casesit appears
in - throw an expection if the object is null.

Tests run: 2413, Failures: 0, Errors: 0, Skipped: 22

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 39:56 min
[INFO] Finished at: 2014-12-11T12:21:29+00:00
[INFO] Final Memory: 43M/479M
[INFO] ------------------------------------------------------------------------


Thanks,

Robert Levas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message