ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 28922: Upgrade Execute: add pre- and post-cluster execute tasks
Date Thu, 11 Dec 2014 01:49:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28922/#review64664
-----------------------------------------------------------

Ship it!


Looks good.  One unused import.


ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
<https://reviews.apache.org/r/28922/#comment107462>

    unused


- Tom Beerbower


On Dec. 10, 2014, 11:25 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28922/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 11:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8574
>     https://issues.apache.org/jira/browse/AMBARI-8574
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added pre- and post- hooks in xml and processing.  Also added a server-side action for
the upcoming Manual tasks that (currently) just no-op.  They'll be filled in later.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 974acd4

>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
9cce147 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ManualStageAction.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8201a8b

>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
c45f005 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 9643e87 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
7d986c9 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 3ff9942

>   ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 5a6dc92

> 
> Diff: https://reviews.apache.org/r/28922/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 2407, Failures: 0, Errors: 0, Skipped: 22
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 22:25.044s
> [INFO] Finished at: Wed Dec 10 18:14:33 EST 2014
> [INFO] Final Memory: 31M/330M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message