ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 28901: Allow for service-level Kerberos descriptor to contain multiple services
Date Wed, 10 Dec 2014 23:08:48 GMT


> On Dec. 10, 2014, 11:01 p.m., John Speidel wrote:
> > looks like you need to rebase your patch

never mind, seems that it was already pushed but the review wasn't closed


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28901/#review64655
-----------------------------------------------------------


On Dec. 10, 2014, 2:25 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28901/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 2:25 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, John Speidel, Robert Nettleton, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-8627
>     https://issues.apache.org/jira/browse/AMBARI-8627
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Current Kerberos descriptor handlers assume only a single service may be identified in
a service-level Kerberos descriptor file.  However services like YARN include the MAPREDUCE2
service, thus multiple services need to be acknowledged.
> 
> The new format is
> ```
> {
>   "services" : [
>     ... 0 or more service blocks ...
>   ]
> }
> ```
> 
> Also added some exception throwing for validation.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
b18e412 
>   ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptor.java
1e33e68 
>   ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
14ba19d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java
12b588c 
>   ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
e882984 
>   ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
d905522 
>   ambari-server/src/test/resources/service_level_kerberos.json PRE-CREATION 
>   ambari-server/src/test/resources/service_level_kerberos_invalid.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28901/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests:
> * org.apache.ambari.server.state.kerberos.KerberosServiceDescriptorTest
> * org.apache.ambari.server.state.kerberos.KerberosDescriptorTest
> 
> Running org.apache.ambari.server.state.kerberos.KerberosDescriptorTest
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.271 sec
> 
> Running org.apache.ambari.server.state.kerberos.KerberosServiceDescriptorTest
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.208 sec
> 
> Full Test Suite:
> Tests run: 2408, Failures: 0, Errors: 0, Skipped: 22
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message