ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 28866: Distribute repositories action: Add command report parsing (INSTALLING->INSTALLED) transition
Date Wed, 10 Dec 2014 21:32:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28866/
-----------------------------------------------------------

(Updated Dec. 10, 2014, 9:32 p.m.)


Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Nate Cole, and Yurii Shylov.


Bugs: AMBARI-8618
    https://issues.apache.org/jira/browse/AMBARI-8618


Repository: ambari


Description (updated)
-------

Patch seems to be working end-to-end. UI team may use it for testing. 


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/RoleCommand.java b98c50c 
  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java 6d1d87f

  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
b3dcca4 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java d482109

  ambari-server/src/main/java/org/apache/ambari/server/bootstrap/DistributeRepositoriesStructuredOutput.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
9b7c3c9 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
2886266 
  ambari-server/src/main/java/org/apache/ambari/server/events/ActionFinalReportReceivedEvent.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java e708473 
  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java 1ce4a73

  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 3308f83 
  ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 1f14ece

  ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java a8abd71

  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java
3da931f 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java
ed1318c 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
e61c1a9 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java ff406b3

  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
f48381c 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java
d387732 

Diff: https://reviews.apache.org/r/28866/diff/


Testing (updated)
-------

Fixed/ignored unit tests, mvn clean test passes. Will fix ignored tests and add new tests
in a separate jira.


The only fainling unit test is irrelevant to my patch:

ERROR: testLastAgentEnv (TestCheckHost.TestCheckHost)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/media/plextor/ambari/ambari-common/src/test/python/mock/mock.py", line 1191, in patched
    arg = patching.__enter__()
  File "/media/plextor/ambari/ambari-common/src/test/python/mock/mock.py", line 1266, in __enter__
    original, local = self.get_original()
  File "/media/plextor/ambari/ambari-common/src/test/python/mock/mock.py", line 1240, in get_original
    "%s does not have the attribute %r" % (target, name)
AttributeError: <class 'ambari_agent.HostInfo.HostInfo'> does not have the attribute
'checkIptables'

----------------------------------------------------------------------


Thanks,

Dmitro Lisnichenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message