ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Review Request 28823: AlertTargets Should Allow AlertGroup Associations To Be Modified From POST
Date Mon, 08 Dec 2014 21:57:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28823/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Tom Beerbower.


Bugs: AMBARI-8595
    https://issues.apache.org/jira/browse/AMBARI-8595


Repository: ambari


Description
-------

When updating or creating an AlertTarget, the AlertGroup associations for that AlertTarget
should be able to modified. 

{code}
PUT http://localhost:8080/api/v1/alert_targets/1

{
  "AlertTarget": {
    "groups": [1,2]
  }
}
{code}

{code}
POST http://localhost:8080/api/v1/alert_targets/1

{
  "AlertTarget": {
    "name": "Simple",
    "description": "This target does not work",
    "notification_type": "FOO",
    "groups": [1,2,3]
  }
}
{code}


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
adb761b 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java 35c9ae4

  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java
6607fb0 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java
146fe49 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java
367e6d4 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java 76a9ee2


Diff: https://reviews.apache.org/r/28823/diff/


Testing
-------

Manually tested creation and updating groups via the alert target. New unit tests written
to cover new methods and functionality.


Thanks,

Jonathan Hurley


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message