ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 28799: Update Apache Directory Server Library from 1.5.5 to 2.0.0-M17
Date Mon, 08 Dec 2014 15:52:24 GMT


> On Dec. 8, 2014, 10:41 a.m., Nate Cole wrote:
> > Why are there multiple LDAP tests - with space and (presumably) no space.  Can't
they be the same test class with different methods and do away with the base class?

I don't know, they aren't tests related to the patch I need the new libraries for. I just
needed to bring them up-to-date.


> On Dec. 8, 2014, 10:41 a.m., Nate Cole wrote:
> > ambari-project/pom.xml, lines 212-220
> > <https://reviews.apache.org/r/28799/diff/1/?file=785403#file785403line212>
> >
> >     M19 is currently the latest?  In general, not a huge fan of M- builds since
it doesn't seem like they're quite production ready.  But if it's working so be it.

I will update to use M19, when I originally started down this path the version was M17 (which
wasn't updated since 7/2014)

I agree about the M-builds, but the fix I need isn't in any of the 1.5.x versions - which
is now labeled "not maintained"


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28799/#review64228
-----------------------------------------------------------


On Dec. 8, 2014, 10:28 a.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28799/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 10:28 a.m.)
> 
> 
> Review request for Ambari, dilli dorai, John Speidel, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-8578
>     https://issues.apache.org/jira/browse/AMBARI-8578
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Update Apache Directory Server Library from 1.5.5 to 2.0.0-M17 to obtain bug fixes needed
for future patches. 
> 
> One fix in particular is [DIRSERVER-1882](https://issues.apache.org/jira/browse/DIRSERVER-1882).
> 
> Currently, the only dependency on this library are unit test cases:
> * org.apache.ambari.server.security.authorization.AmbariLdapAuthenticationProviderTest
> * org.apache.ambari.server.security.authorization.AmbariLdapAuthenticationProviderForDNWithSpaceTest
> * org.apache.ambari.server.security.authorization.AmbariLdapAuthenticationProviderBaseTest
> 
> These need to be updated to support the new library and associated dependencies. 
> 
> 
> Diffs
> -----
> 
>   ambari-project/pom.xml edba1dc 
>   ambari-server/pom.xml 4076d73 
>   ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderBaseTest.java
2a323f8 
>   ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDNWithSpaceTest.java
c04af86 
>   ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
6bc692c 
>   ambari-server/src/test/resources/users.ldif 1f8557e 
>   ambari-server/src/test/resources/users_for_dn_with_space.ldif 5e8f8cf 
> 
> Diff: https://reviews.apache.org/r/28799/diff/
> 
> 
> Testing
> -------
> 
> Ran updated unit tests (inculuded with full test suite)
> 
> Running org.apache.ambari.server.security.authorization.AmbariLdapAuthenticationProviderForDNWithSpaceTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 52.596 sec
> 
> Running org.apache.ambari.server.security.authorization.AmbariLdapAuthenticationProviderTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 54.837 sec
> 
> Full Suite Results:
> Tests run: 2327, Failures: 0, Errors: 0, Skipped: 22
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:58 min
> [INFO] Finished at: 2014-12-08T06:31:40+00:00
> [INFO] Final Memory: 43M/479M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message