ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin Jetly" <jai...@hortonworks.com>
Subject Re: Review Request 28780: Kerberos Wizard: Implement "Kerberize Cluster" page and "Test Services" page.
Date Sat, 06 Dec 2014 01:31:09 GMT


> On Dec. 6, 2014, 1:22 a.m., Yusaku Sako wrote:
> > ambari-web/app/assets/data/wizard/kerberos/kerberize_cluster.json, line 1
> > <https://reviews.apache.org/r/28780/diff/1/?file=784282#file784282line1>
> >
> >     JSON files should not have license header (should be ignored by rat check exclude
rule).

Updated the second diff addressing this issue


> On Dec. 6, 2014, 1:22 a.m., Yusaku Sako wrote:
> > ambari-web/app/templates/main/admin/kerberos/step5.hbs, line 18
> > <https://reviews.apache.org/r/28780/diff/1/?file=784294#file784294line18>
> >
> >     Why "highAvailablity" here?

Thats the common template used accross ambari wizards (HA wizard progress pages, move master
wizard progress pages and kerberos wizard progress pages) for wizard progress disaply page.

It makes sense moving this template file it to the more generic loation like commons directory.
That will also require changing it's references in all other wizards along with the kerberos
wizard.
We can do that refactoring as a seperate task.


- Jaimin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28780/#review64139
-----------------------------------------------------------


On Dec. 6, 2014, 1:22 a.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28780/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2014, 1:22 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
> 
> 
> Bugs: AMBARI-8572
>     https://issues.apache.org/jira/browse/AMBARI-8572
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Apart from implementing "Kerberize Cluster" page and "Test services" page, this patch
also removes KDC service component from Kerberos metainfo.xml.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml 8751892

>   ambari-web/app/assets/data/wizard/kerberos/kerberize_cluster.json PRE-CREATION 
>   ambari-web/app/controllers/main/admin/kerberos/step2_controller.js f674f4a 
>   ambari-web/app/controllers/main/admin/kerberos/step3_controller.js 3a4fdbd 
>   ambari-web/app/controllers/main/admin/kerberos/step5_controller.js b15c8cf 
>   ambari-web/app/controllers/main/admin/kerberos/step6_controller.js 800e0c8 
>   ambari-web/app/data/HDP2/site_properties.js 7971b6a 
>   ambari-web/app/messages.js 7396499 
>   ambari-web/app/mixins/wizard/wizardProgressPageController.js 63a5fc7 
>   ambari-web/app/mixins/wizard/wizardProgressPageView.js bbb6420 
>   ambari-web/app/models/cluster_states.js 9571ea4 
>   ambari-web/app/routes/add_kerberos_routes.js 4afaedb 
>   ambari-web/app/templates/main/admin/highAvailability/progress.hbs 5f95387 
>   ambari-web/app/templates/main/admin/kerberos/step5.hbs eadc752 
>   ambari-web/app/utils/ajax/ajax.js 3d9206e 
>   ambari-web/app/views/main/admin/kerberos/step5_view.js bf46584 
>   ambari-web/app/views/main/admin/kerberos/wizard_view.js d82786a 
> 
> Diff: https://reviews.apache.org/r/28780/diff/
> 
> 
> Testing
> -------
> 
> tested kerberos wizard on a live cluster
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message