ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard Zang" <rz...@hortonworks.com>
Subject Re: Review Request 28736: Ambari View > Versions > Versions table + Registration E2E integration
Date Sat, 06 Dec 2014 00:20:22 GMT


> On Dec. 5, 2014, 3:41 a.m., Yusaku Sako wrote:
> > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js,
line 44
> > <https://reviews.apache.org/r/28736/diff/1/?file=783447#file783447line44>
> >
> >     Operating systems and repo names should not be hardcoded.  These should be derived
from the stack definition (especially the repo names).
> >     We should either fix it in this JIRA, or open another JIRA to address these
and add TODO comments in the code.

Add TODO comment


> On Dec. 5, 2014, 3:41 a.m., Yusaku Sako wrote:
> > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js,
line 27
> > <https://reviews.apache.org/r/28736/diff/1/?file=783448#file783448line27>
> >
> >     These should be retrieved from the stack definition.  We need to retrieve stacks
that have an upgrade pack associated.
> >     Either fix in this JIRA or create another JIRA/add TODO comment.

Add TODO comment


> On Dec. 5, 2014, 3:41 a.m., Yusaku Sako wrote:
> > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/StackVersions.js,
line 57
> > <https://reviews.apache.org/r/28736/diff/1/?file=783450#file783450line57>
> >
> >     HDP should not be hardcoded.  Fix or TODO.

Add TODO comment


- Richard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28736/#review63956
-----------------------------------------------------------


On Dec. 6, 2014, 12:19 a.m., Richard Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28736/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2014, 12:19 a.m.)
> 
> 
> Review request for Ambari, Andrii Tkach and Yusaku Sako.
> 
> 
> Bugs: AMBARI-8554
>     https://issues.apache.org/jira/browse/AMBARI-8554
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari View > Versions > Versions table + Registration E2E integration
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/assets/data/cluster/clusters.json
PRE-CREATION 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
ae984b8 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js
698bc6c 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js c474918

>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/StackVersions.js
ae499cc 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/create.html 11e954f

>   ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html 97e67c9

> 
> Diff: https://reviews.apache.org/r/28736/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on live cluster. No unit test applicable.
> 
> 
> Thanks,
> 
> Richard Zang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message