ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Sposetti" <j...@hortonworks.com>
Subject Re: Review Request 28661: Simple view example with UI resources
Date Thu, 04 Dec 2014 02:08:45 GMT


> On Dec. 3, 2014, 10:50 p.m., Tom Beerbower wrote:
> > ambari-views/examples/simple-view/src/main/resources/ui/jquery.min.js, lines 1-3
> > <https://reviews.apache.org/r/28661/diff/1/?file=781869#file781869line1>
> >
> >     Is this generated?  Does the file require a license header?

Downloaded from jquery http://jquery.com/download/

We could (instead) just point to the hosted file and not include this checked in? I'm up for
either.


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28661/#review63769
-----------------------------------------------------------


On Dec. 4, 2014, 2:08 a.m., Jeff Sposetti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28661/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 2:08 a.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Yusaku Sako.
> 
> 
> Bugs: AMBARI-8257
>     https://issues.apache.org/jira/browse/AMBARI-8257
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 
> A simple view example that also includes both UI resources and REST endpoint.
> 
> 
> Diffs
> -----
> 
>   ambari-views/examples/simple-view/docs/index.md PRE-CREATION 
>   ambari-views/examples/simple-view/pom.xml PRE-CREATION 
>   ambari-views/examples/simple-view/src/main/java/org/apache/ambari/view/simple/SimpleService.java
PRE-CREATION 
>   ambari-views/examples/simple-view/src/main/resources/ui/index.html PRE-CREATION 
>   ambari-views/examples/simple-view/src/main/resources/view.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28661/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jeff Sposetti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message