ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 28680: Views: Files, UI and trash
Date Wed, 03 Dec 2014 23:56:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28680/#review63779
-----------------------------------------------------------

Ship it!


One question... looks good otherwise.


contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java
<https://reviews.apache.org/r/28680/#comment106086>

    Not sure under what conditions this will throw an Exception but it looks like the caller
above will in turn throw a ServiceFormattedException.  Is that appropriate?


- Tom Beerbower


On Dec. 3, 2014, 11:26 p.m., Jeff Sposetti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28680/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 11:26 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Erik Bergenholtz, Tom Beerbower, and Yusaku
Sako.
> 
> 
> Bugs: AMBARI-8536
>     https://issues.apache.org/jira/browse/AMBARI-8536
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 
>     minor UI (do not link if file/directory is not readable)
>     added a readme
>     handle trash as a "move" operation
> 
> 
> Diffs
> -----
> 
>   contrib/views/files/readme.md PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java
444899f 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java fcc4d16

>   contrib/views/files/src/main/resources/ui/app/templates/util/fileRow.hbs 50693b0 
> 
> Diff: https://reviews.apache.org/r/28680/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jeff Sposetti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message