ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 28615: Alerts: Create A Global Alert Target For All Alert Groups
Date Wed, 03 Dec 2014 19:18:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28615/#review63709
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Dec. 3, 2014, 7:08 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28615/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 7:08 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8514
>     https://issues.apache.org/jira/browse/AMBARI-8514
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently, there is no easy way to assign a single alert target to all of the alert groups
defined in the new alerts framework. The user will need to manually associate each alert target
with the existing alert groups. Furthermore, new groups will not automatically be associated
with any alert targets in the system.
> 
> There should be the ability to specify that an alert target is a global catch-all. Once
created, the alert target will automatically be associated with any existing and newly created
alert groups.
> 
> The alert target will be denoted as being "global", making its associated groups read-only
since they will always include all of the groups defined in the system.
> 
> This will also enable the web client to prompt the administrator during a cluster install
to define a global alert target that will begin working for them immediately after the cluster
install has completed.
> 
> To create a global alert target:
> ```
> {
>   "AlertTarget": {
>     "name": "Global Email",
>     "description": "Email for all triggered alerts.",
>     "global": true,
>     "notification_type": "EMAIL",
>     "properties":{
>        ...
>     }    
>   }
> ```
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertGroupService.java
12cdb70 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
2e13cdc 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java
47fd65b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
1458139 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java
3a3ad15 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java
9f24dc3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertGroup.java 659efa9

>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertTarget.java 2d10dda

>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
79e0daa 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4bd374d 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 9eb4e3a 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql e8f20f6 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 059662f 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 232b283 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java
de91943 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java
0d081f8 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 0c93ec2

>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
3d8f898 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java
c920905 
> 
> Diff: https://reviews.apache.org/r/28615/diff/
> 
> 
> Testing
> -------
> 
> New tests added to cover the global alert target. Manually created a global target and
verified that it automatically received notifications.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message