ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksandr Kovalenko" <akovale...@hortonworks.com>
Subject Re: Review Request 28650: Alerts UI: Create Notification dialog should have ability to add extra configs
Date Wed, 03 Dec 2014 16:19:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28650/#review63679
-----------------------------------------------------------

Ship it!


Ship It!

- Aleksandr Kovalenko


On Гру. 3, 2014, 4:18 після полудня, Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28650/
> -----------------------------------------------------------
> 
> (Updated Гру. 3, 2014, 4:18 після полудня)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: ambari-8526
>     https://issues.apache.org/jira/browse/ambari-8526
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create Alert Notification dialog should have a generic way (irrespective of _Method_)
to add and remove new configs. There should be an an {{Add}} button which will take in a key/value.
Added configs should be removable.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/data/alerts/alertNotifications.json 8e19655 
>   ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js a6d13b1

>   ambari-web/app/messages.js e148eb6 
>   ambari-web/app/styles/alerts.less df07714 
>   ambari-web/app/templates/main/alerts/add_custom_config_to_alert_notification_popup.hbs
PRE-CREATION 
>   ambari-web/app/templates/main/alerts/create_alert_notification.hbs 37ac7a9 
>   ambari-web/app/utils/ajax/ajax.js 662c9b8 
>   ambari-web/app/utils/validator.js d1af967 
>   ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
15f9ede 
> 
> Diff: https://reviews.apache.org/r/28650/diff/
> 
> 
> Testing
> -------
> 
>   5013 tests complete (7 seconds)
>   60 tests pending
>   
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message