Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1F26810FCB for ; Wed, 26 Nov 2014 00:22:23 +0000 (UTC) Received: (qmail 83935 invoked by uid 500); 26 Nov 2014 00:22:23 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 83903 invoked by uid 500); 26 Nov 2014 00:22:23 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 83887 invoked by uid 99); 26 Nov 2014 00:22:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Nov 2014 00:22:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 68C9F1FB7C3; Wed, 26 Nov 2014 00:22:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0129477162768764518==" MIME-Version: 1.0 Subject: Re: Review Request 28455: Alerts UI: Cluster level alert-definitions table has multiple issues From: "Xi Wang" To: "Yusaku Sako" , "Jaimin Jetly" Cc: "Ambari" , "Xi Wang" Date: Wed, 26 Nov 2014 00:22:21 -0000 Message-ID: <20141126002221.15977.21177@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Xi Wang" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/28455/ X-Sender: "Xi Wang" References: <20141125233046.15978.55679@reviews.apache.org> In-Reply-To: <20141125233046.15978.55679@reviews.apache.org> Reply-To: "Xi Wang" X-ReviewRequest-Repository: ambari --===============0129477162768764518== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28455/ ----------------------------------------------------------- (Updated Nov. 25, 2014, 4:22 p.m.) Review request for Ambari, Jaimin Jetly and Yusaku Sako. Bugs: AMBARI-8448 https://issues.apache.org/jira/browse/AMBARI-8448 Repository: ambari Description ------- # Alert-groups combo contents should be sorted alphabetically. (also, All Default groups at top, followed by customized groups) # Alert-groups combo should look like the Filter combo on Hosts page {{Groups: All(54)}}, or {{Groups: YARN Default (18)}}. # Move Actions combo to the left of Alert-groups combo # Summary table default sort order should be the severity of status in descending value - Criticals count > Warnings count > OK count # Enabled disabled column should have a filter with options {{All|Enabled|Disabled}}. Each should show in text {{Enabled}} or {{Disabled}}. The icon should be to the right of the text and will be the action to enable/disable. # Enable/Disable action should ask for confirmation # Footer text {{58 of 58 alerts showing - clear filters}} should be changed to {{58 of 58 definitions showing - clear filters}} # Column title {{Name}} should be changed to {{Definition Name}} Diffs (updated) ----- ambari-web/app/controllers/main/alert_definitions_controller.js 88c9ff7 ambari-web/app/messages.js 5a7ff55 ambari-web/app/models/alert_definition.js 9d5f52c ambari-web/app/styles/alerts.less af69fe8 ambari-web/app/styles/application.less ab0558b ambari-web/app/templates/main/alerts.hbs fb53f17 ambari-web/app/views/common/filter_view.js 1efcb72 ambari-web/app/views/common/sort_view.js e66630c ambari-web/app/views/main/alert_definitions_view.js c8535cc ambari-web/test/controllers/main/alert_definitions_controller_test.js a605899 Diff: https://reviews.apache.org/r/28455/diff/ Testing ------- unit tests passed Thanks, Xi Wang --===============0129477162768764518==--