Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============5692759971461737560=="
MIME-Version: 1.0
Subject: Re: Review Request 28311: Upgrade Execute: implement proper RESTART
 commands
From: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>,
 "Yurii Shylov" <yurii.shylov@gmail.com>
Cc: "Nate Cole" <ncole@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Fri, 21 Nov 2014 14:11:25 -0000
Message-ID: <20141121141125.15325.22248@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Dmitro Lisnichenko" <noreply@reviews.apache.org>
References: <20141121125135.15325.22446@reviews.apache.org>
In-Reply-To: <20141121125135.15325.22446@reviews.apache.org>
Reply-To: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>

--===============5692759971461737560==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Nov. 21, 2014, 12:51 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, line 574
> > <https://reviews.apache.org/r/28311/diff/1/?file=771830#file771830line574>
> >
> >     The second argument is not a cluster name, it's a log directory.  It's apparently unused (and I don't even know why it's there in the first place, no one knows :) ).  I'm working on having it removed.

Sorry, I checked parameter order without your patch applied. You are right.


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28311/#review62542
-----------------------------------------------------------


On Nov. 21, 2014, 2:43 a.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28311/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2014, 2:43 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-8406
>     https://issues.apache.org/jira/browse/AMBARI-8406
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Replace stub restart with an actual restart command.  Needed a slight refactor to move required common code out of AMCI
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 4103621 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 9d3a1f8 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteCommandJson.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9138ec2 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java e068508 
> 
> Diff: https://reviews.apache.org/r/28311/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:02.228s
> [INFO] Finished at: Thu Nov 20 21:43:10 EST 2014
> [INFO] Final Memory: 30M/666M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


--===============5692759971461737560==--