Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 36B05114E2 for ; Thu, 20 Nov 2014 20:23:01 +0000 (UTC) Received: (qmail 81860 invoked by uid 500); 20 Nov 2014 20:22:56 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 81832 invoked by uid 500); 20 Nov 2014 20:22:56 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 81816 invoked by uid 99); 20 Nov 2014 20:22:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Nov 2014 20:22:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E8A74116FD2; Thu, 20 Nov 2014 20:22:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7401459951480405831==" MIME-Version: 1.0 Subject: Re: Review Request 28259: Remove legacy Nagios alerts code from Ambari Web From: "Xi Wang" To: "Yusaku Sako" , "Srimanth Gunturi" Cc: "Ambari" , "Xi Wang" Date: Thu, 20 Nov 2014 20:22:54 -0000 Message-ID: <20141120202254.16171.24639@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Xi Wang" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/28259/ X-Sender: "Xi Wang" References: <20141119205512.15353.57202@reviews.apache.org> In-Reply-To: <20141119205512.15353.57202@reviews.apache.org> Reply-To: "Xi Wang" X-ReviewRequest-Repository: ambari --===============7401459951480405831== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28259/ ----------------------------------------------------------- (Updated Nov. 20, 2014, 12:22 p.m.) Review request for Ambari, Srimanth Gunturi and Yusaku Sako. Bugs: AMBARI-8388 https://issues.apache.org/jira/browse/AMBARI-8388 Repository: ambari Description ------- Nagios is no longer available as a service in trunk. Ambari Web needs to remove calls to get legacy_alerts, as this will no longer work once the server code removes the provider for Nagios alerts. As part of this ticket, remove legacy_alerts from being requested and make sure that the general UI does not break. Diffs (updated) ----- ambari-web/app/assets/test/tests.js c831716 ambari-web/app/controllers.js c4385ce ambari-web/app/controllers/global/update_controller.js bfb625c ambari-web/app/controllers/main/alerts_controller.js b28f711 ambari-web/app/controllers/main/host.js dc966db ambari-web/app/messages.js 9943582 ambari-web/app/routes/main.js 361312b ambari-web/app/templates/main/dashboard/alert_notification_popup.hbs 8a37e23 ambari-web/app/templates/main/host/alerts_popup.hbs 247753a ambari-web/app/templates/main/service/info/summary.hbs 8ccc64e ambari-web/app/utils/ajax/ajax.js d4a8402 ambari-web/app/views/main/dashboard/widgets.js 29b7063 ambari-web/app/views/main/service/info/summary.js 99c049b ambari-web/test/controllers/main/alerts_controller_test.js aee782a ambari-web/test/views/main/service/info/summary_test.js f64ee18 Diff: https://reviews.apache.org/r/28259/diff/ Testing ------- tested Thanks, Xi Wang --===============7401459951480405831==--