Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9116F1088F for ; Mon, 17 Nov 2014 23:53:53 +0000 (UTC) Received: (qmail 14602 invoked by uid 500); 17 Nov 2014 23:53:53 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 14570 invoked by uid 500); 17 Nov 2014 23:53:53 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 14556 invoked by uid 99); 17 Nov 2014 23:53:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Nov 2014 23:53:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9772B1165B3; Mon, 17 Nov 2014 23:53:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2589284741560369682==" MIME-Version: 1.0 Subject: Review Request 28138: Alerts UI: create unit tests for manage alert groups From: "Xi Wang" To: "Aleksandr Kovalenko" , "Srimanth Gunturi" Cc: "Xi Wang" , "Ambari" Date: Mon, 17 Nov 2014 23:53:52 -0000 Message-ID: <20141117235352.24717.31039@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Xi Wang" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/28138/ X-Sender: "Xi Wang" Reply-To: "Xi Wang" X-ReviewRequest-Repository: ambari --===============2589284741560369682== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28138/ ----------------------------------------------------------- Review request for Ambari, Aleksandr Kovalenko and Srimanth Gunturi. Bugs: AMBARI-8359 https://issues.apache.org/jira/browse/AMBARI-8359 Repository: ambari Description ------- Add unit tests for manage alert groups including: 1. Testing operations on alert groups. 2. Testing operations on an alert group's definitions. Diffs ----- ambari-web/app/assets/test/tests.js 194a806 ambari-web/app/views/main/alert_definitions_view.js 6e9c276 ambari-web/test/controllers/main/alerts/manage_alert_groups_controller_test.js PRE-CREATION Diff: https://reviews.apache.org/r/28138/diff/ Testing ------- Units tests passed Thanks, Xi Wang --===============2589284741560369682==--